Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Update the build #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update the build #72

wants to merge 3 commits into from

Conversation

Jawnnypoo
Copy link

Just wanted to make this easier for the next person who pulls down the repo and wants to build.

Bump build tools, target sdk, and target Java 7 so that it does not break builds which try to compile with Java 8 (which is what Android Studio was trying to compile with by default for me)

This will also allow for users to use newer features like instant run when developing. Always a plus!

…reak builds which try to compile with Java 8
@ghost ghost added the CLA Signed label May 3, 2016
@Jawnnypoo
Copy link
Author

Jawnnypoo commented May 17, 2016

allprojects {
     sourceCompatibility = JavaVersion.VERSION_1_7
     targetCompatibility = JavaVersion.VERSION_1_7
 }

Do you guys have any ideas as to why this is needed or why this was not an issue before? It may have just been an issue for me, since I have JDK 8 installed and maybe Android Studio was just compiling to the latest. Regardless, I think it would be nice to have this in here explicit for anyone else who might run into this issue. I suppose others were encountering it, after seeing issue #71

@Jawnnypoo
Copy link
Author

@willbailey Any chance of reviewing this? It is an issue any developer who wants to make updates will probably run into.

Case in point, #77 already repeats some of the work done here.

Is this library still being maintained?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant