Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Update the gradle version and new JDK issue #77

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adilek
Copy link

@adilek adilek commented Aug 16, 2016

It was not able to compile with new gradle version and also JDK 8.
So the gradle version is updated and lint issue is solved to remove the gradle issue.

With this patch it is possible to compile with JDK8 also (however it is uses JDK7 mode because of com.facebook.rebound.SynchronousLooper)

@ghost
Copy link

ghost commented Aug 16, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@danielgomezrico
Copy link

any update on this?

@adilek
Copy link
Author

adilek commented Jan 27, 2017

Not yet. ))) No one wants to merge it.

@zhiqizhu
Copy link

Can anyone merge this?

@knightkill
Copy link

It's about to be year to this PR... Don't know what they are so much testing about in just 4 files. Please guys merge this so people can use this wonderful piece of code :)

@adilek
Copy link
Author

adilek commented Jul 17, 2017

New versions of gradle were released )))))))

@knightkill
Copy link

But still gradle version is 1.2.3 which is not supported by current Android Studio version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants