-
Notifications
You must be signed in to change notification settings - Fork 818
Update the gradle version and new JDK issue #77
base: master
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
any update on this? |
Not yet. ))) No one wants to merge it. |
Can anyone merge this? |
It's about to be year to this PR... Don't know what they are so much testing about in just 4 files. Please guys merge this so people can use this wonderful piece of code :) |
New versions of gradle were released ))))))) |
But still gradle version is 1.2.3 which is not supported by current Android Studio version. |
It was not able to compile with new gradle version and also JDK 8.
So the gradle version is updated and lint issue is solved to remove the gradle issue.
With this patch it is possible to compile with JDK8 also (however it is uses JDK7 mode because of com.facebook.rebound.SynchronousLooper)