Standardize and fix copyright and licenses #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All copyright lines now have -2020 instead of -present
* All copyright lines include "Facebook, Inc"
* All licenses are now standardized
The copyright in `threading.{h,c}` is not changed because it comes from
zstdmt.
The copyright and license of `divsufsort.{h,c}` is not changed.
Tests all `.h`, `.c`, `.py`, and `Makefile` files for valid copyright and license lines. Excludes a small number of exceptions (threading, and divsufsort). * Copyright does not contains `present` * Copyright contains `Facebook, Inc` * Copyright contains the current year * License contains exactly the lines we expect
|
CircleCI isn't running on my repo, which means it doesn't run on my PRs... It seems that I have ~100 jobs stuck as "running". To be investigated before landing. |
Run it first because it is very fast (~1 second)
|
CircleCI is running on my PRs now, and the test passed as expected https://circleci.com/gh/facebook/zstd/5769?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link (first line is |
|
The FreeBSD failure seems unrelated. |
Cyan4973
reviewed
Mar 27, 2020
| @@ -12,6 +12,7 @@ jobs: | |||
| - run: | |||
| name: Test | |||
| command: | | |||
| ./tests/test-license.py | |||
Cyan4973
approved these changes
Mar 27, 2020
Arcovion
reviewed
Mar 27, 2020
| # All rights reserved. | ||
| # | ||
| # This source code is licensed under both the BSD-style license (found in the | ||
| # LICENSE file in the root directory of this source tree) and the GPLv2 (found | ||
| # in the COPYING file in the root directory of this source tree). | ||
| # You may select, at your option, one of the above-listed licenses. |
There was a problem hiding this comment.
'at your discretion' sounds more natural to me than 'at your option'
There was a problem hiding this comment.
I agree, but to change it we would have to talk to our lawyers, and it isn't worth the hassle unless the wording is causing problems for someone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copyright in
threading.{h,c}is not changed because it comes from zstdmt. The copyright and license ofdivsufsort.{h,c}is not changed.Fixes #2052