Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License concern #2052

Closed
zhangfuwen opened this issue Mar 26, 2020 · 2 comments · Fixed by #2054
Closed

License concern #2052

zhangfuwen opened this issue Mar 26, 2020 · 2 comments · Fixed by #2054

Comments

@zhangfuwen
Copy link

Hi,

We are using zstd, and are now encountering a license problem and we hope you can help us with some clarification or modification.
zstd is basically a dual license project but we've found three files have a different license announcement with other files.
one of the different files is zstd/lib/compress/zstd_ldm.c.

Other files' license announcement says dual license and

You may select, at your option, one of the above-listed licenses.

zstd_ldm.c doesn't have the last statement. Our company's legal team says in this situation we have to select the stricter license which is GPLv2 (which we don't want to use).

Is the absence of the last statement a negligence or is it intended ?

If it is a negligence, can we modify it and add the statement?

license annoucement in zstd_ldm.c:

/*
 * Copyright (c) 2016-present, Yann Collet, Facebook, Inc.
 * All rights reserved.
 *
 * This source code is licensed under both the BSD-style license (found in the
 * LICENSE file in the root directory of this source tree) and the GPLv2 (found
 * in the COPYING file in the root directory of this source tree).
 */

license announcement in other files:

/*
 * Copyright (c) 2016-present, Yann Collet, Facebook, Inc.
 * All rights reserved.
 *
 * This source code is licensed under both the BSD-style license (found in the
 * LICENSE file in the root directory of this source tree) and the GPLv2 (found
 * in the COPYING file in the root directory of this source tree).
 * You may select, at your option, one of the above-listed licenses.
 */

all files without the last statement:

https://github.com/facebook/zstd/blob/dev/lib/compress/zstd_ldm.c
https://github.com/facebook/zstd/blob/dev/lib/common/threading.h
https://github.com/facebook/zstd/blob/dev/lib/compress/zstd_ldm.h

@terrelln
Copy link
Contributor

This is a mistake, all files in lib/ are dual licensed. I will put up a PR to fix it tomorrow.

@terrelln
Copy link
Contributor

This should be fixed now, let us know if you have any further concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants