Add ASAN CircleCI Run #7027
Add ASAN CircleCI Run #7027
Conversation
|
@mrambacher hmm... maybe. How should we proceed? Wait for #6659, or make #6659 rebase later? |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
.circleci/config.yml
Outdated
| steps: | ||
| - checkout # check out the code in the project directory | ||
| - run: pyenv global 3.5.2 | ||
| - run: sudo sh -c 'echo "deb http://apt.llvm.org/xenial/ llvm-toolchain-xenial-10 main" >> /etc/apt/sources.list' |
There was a problem hiding this comment.
Optional: you could probably simplify to echo "stuff" | sudo tee -a /etc/apt/sources.list
.circleci/config.yml
Outdated
| - run: sudo apt-get update -y | ||
| - run: sudo apt-get install -y clang-10 | ||
| - run: sudo apt-get install -y libgflags-dev | ||
| - run: SKIP_FORMAT_BUCK_CHECKS=1 COMPILE_WITH_ASAN=1=1 CC=clang-10 CXX=clang++-10 ROCKSDB_DISABLE_ALIGNED_NEW=1 USE_CLANG=1 PRINT_PARALLEL_OUTPUTS=1 make asan_check -j32 # aligned new doesn't work for reason we haven't figured out |
There was a problem hiding this comment.
Unintentional =1=1 but I think still works
|
@siying has updated the pull request. Re-import the pull request |
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request has been merged in 7006997. |
ASAN run is powerful in finding memory leak bugs. Running it as a part of the pre-merge CI can help contributors avoid to merge some code with bugs.
Test Plan: Watch the test result.