Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CircleCI with CLANG-10 #7025

Closed
wants to merge 1 commit into from
Closed

Conversation

siying
Copy link
Contributor

@siying siying commented Jun 24, 2020

Summary:
It's useful to build RocksDB using a more recent clang version in CI. Add a CircleCI build and fix some issues with it.

Test Plan: See all tests pass.

@siying siying force-pushed the cci_clang9 branch 3 times, most recently from 6705473 to c8d4d44 Compare June 24, 2020 19:44
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@siying siying requested a review from pdillinger June 24, 2020 19:59
@siying siying changed the title Test CircleCI with CLANG-9 Test CircleCI with CLANG-10 Jun 24, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@pdillinger pdillinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9cc2519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants