Bring back the ability to leverage the primary key in secondary indices #13324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68514201 |
…es (facebook#13324) Summary: There are actually some use cases which would benefit from the ability to use the primary key when forming the secondary key prefix or value. One such use case, which is demonstrated using a unit test, is building a secondary index on non-initial part(s) of the primary key. The patch adds back this ability, which was was removed in facebook#13207, with a twist: the earlier `GetSecondaryKeyPrefix` is essentially split into two parts, with `GetSecondaryKeyPrefix` now being responsible only for computing whatever the secondary index is built on (let's call this "index function result") and a new `FinalizeSecondaryKeyPrefix` method having the responsibility of dealing with serialization concerns like adding a length indicator for disambiguation. This also means a slight change for the `SecondaryIndexIterator` class: it now treats its `Seek` argument as an "index function result" and thus only calls the new `FinalizeSecondaryKeyPrefix` on it (but not `GetSecondaryKeyPrefix`). Differential Revision: D68514201
ltamasi
force-pushed
the
export-D68514201
branch
from
c50bcfc to
4e0ca75
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68514201 |
|
This pull request has been merged in 35a27d8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There are actually some use cases which would benefit from the ability to use the primary key when forming the secondary key prefix or value. One such use case, which is demonstrated using a unit test, is building a secondary index on non-initial part(s) of the primary key. The patch adds back this ability, which was was removed in #13207, with a twist: the earlier
GetSecondaryKeyPrefixis essentially split into two parts, withGetSecondaryKeyPrefixnow being responsible only for computing whatever the secondary index is built on (let's call this "index function result") and a newFinalizeSecondaryKeyPrefixmethod having the responsibility of dealing with serialization concerns like adding a length indicator for disambiguation. This also means a slight change for theSecondaryIndexIteratorclass: it now treats itsSeekargument as an "index function result" and thus only calls the newFinalizeSecondaryKeyPrefixon it (but notGetSecondaryKeyPrefix).Differential Revision: D68514201