Remove the primary_key parameter of SecondaryIndex::GetSecondary{KeyPrefix,Value} #13207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67184936 |
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 13, 2024
Summary: Pull Request resolved: facebook#13207 Differential Revision: D67184936
ltamasi
force-pushed
the
export-D67184936
branch
from
ea79fbe to
63bdb47
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67184936 |
|
great work! |
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 13, 2024
Summary: Pull Request resolved: facebook#13207 Differential Revision: D67184936
ltamasi
force-pushed
the
export-D67184936
branch
from
63bdb47 to
3bddcbf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67184936 |
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 13, 2024
Summary: Pull Request resolved: facebook#13207 Differential Revision: D67184936
ltamasi
force-pushed
the
export-D67184936
branch
from
3bddcbf to
eeb2ebb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67184936 |
…refix,Value} (facebook#13207) Summary: The patch tweaks the new `SecondaryIndex` interface a bit by removing the `primary_key` parameter of `GetSecondaryKeyPrefix` and `GetSecondaryValue`. This parameter is currently unused by existing implementations and it actually does not make sense to have the secondary index prefix depend on the primary key since it would lead to potential chicken-and-egg problems at query time. Differential Revision: D67184936
ltamasi
force-pushed
the
export-D67184936
branch
from
eeb2ebb to
5a29838
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67184936 |
ltamasi
changed the title
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 28, 2024
…refix,Value} (facebook#13207) Summary: The patch tweaks the new `SecondaryIndex` interface a bit by removing the `primary_key` parameter of `GetSecondaryKeyPrefix` and `GetSecondaryValue`. This parameter is currently unused by existing implementations and it actually does not make sense to have the secondary index prefix depend on the primary key since it would lead to potential chicken-and-egg problems at query time. Differential Revision: D67184936
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 28, 2024
…refix,Value} (facebook#13207) Summary: The patch tweaks the new `SecondaryIndex` interface a bit by removing the `primary_key` parameter of `GetSecondaryKeyPrefix` and `GetSecondaryValue`. This parameter is currently unused by existing implementations and it actually does not make sense to have the secondary index prefix depend on the primary key since it would lead to potential chicken-and-egg problems at query time. Differential Revision: D67184936
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 28, 2024
…refix,Value} (facebook#13207) Summary: The patch tweaks the new `SecondaryIndex` interface a bit by removing the `primary_key` parameter of `GetSecondaryKeyPrefix` and `GetSecondaryValue`. This parameter is currently unused by existing implementations and it actually does not make sense to have the secondary index prefix depend on the primary key since it would lead to potential chicken-and-egg problems at query time. Differential Revision: D67184936
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 28, 2024
…refix,Value} (facebook#13207) Summary: The patch tweaks the new `SecondaryIndex` interface a bit by removing the `primary_key` parameter of `GetSecondaryKeyPrefix` and `GetSecondaryValue`. This parameter is currently unused by existing implementations and it actually does not make sense to have the secondary index prefix depend on the primary key since it would lead to potential chicken-and-egg problems at query time. Differential Revision: D67184936
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 28, 2024
…refix,Value} (facebook#13207) Summary: The patch tweaks the new `SecondaryIndex` interface a bit by removing the `primary_key` parameter of `GetSecondaryKeyPrefix` and `GetSecondaryValue`. This parameter is currently unused by existing implementations and it actually does not make sense to have the secondary index prefix depend on the primary key since it would lead to potential chicken-and-egg problems at query time. Differential Revision: D67184936
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 28, 2024
…refix,Value} (facebook#13207) Summary: The patch tweaks the new `SecondaryIndex` interface a bit by removing the `primary_key` parameter of `GetSecondaryKeyPrefix` and `GetSecondaryValue`. This parameter is currently unused by existing implementations and it actually does not make sense to have the secondary index prefix depend on the primary key since it would lead to potential chicken-and-egg problems at query time. Differential Revision: D67184936
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Dec 28, 2024
…refix,Value} (facebook#13207) Summary: The patch tweaks the new `SecondaryIndex` interface a bit by removing the `primary_key` parameter of `GetSecondaryKeyPrefix` and `GetSecondaryValue`. This parameter is currently unused by existing implementations and it actually does not make sense to have the secondary index prefix depend on the primary key since it would lead to potential chicken-and-egg problems at query time. Pull Request resolved: facebook#13207 Differential Revision: D67184936
jaykorean
approved these changes
Dec 30, 2024
|
This pull request has been merged in 3570e4f. |
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Jan 22, 2025
Summary: There are actually some use cases which would benefit from the ability to use the primary key when forming the secondary key prefix or value. One such use case, which is demonstrated using a unit test, is building a secondary index on non-initial part(s) of the primary key. The patch adds back this ability, which was was removed in facebook#13207, with a twist: the earlier `GetSecondaryKeyPrefix` is essentially split into two parts, with `GetSecondaryKeyPrefix` now being responsible only for computing whatever the secondary index is built on (let's call this "index function result") and a new `FinalizeSecondaryKeyPrefix` method having the responsibility of dealing with serialization concerns like adding a length indicator for disambiguation. This also means a slight change for the `SecondaryIndexIterator` class: it now treats its `Seek` argument as an "index function result" and thus only calls the new `FinalizeSecondaryKeyPrefix` on it (but not `GetSecondaryKeyPrefix`). Differential Revision: D68514201
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Jan 22, 2025
…es (facebook#13324) Summary: There are actually some use cases which would benefit from the ability to use the primary key when forming the secondary key prefix or value. One such use case, which is demonstrated using a unit test, is building a secondary index on non-initial part(s) of the primary key. The patch adds back this ability, which was was removed in facebook#13207, with a twist: the earlier `GetSecondaryKeyPrefix` is essentially split into two parts, with `GetSecondaryKeyPrefix` now being responsible only for computing whatever the secondary index is built on (let's call this "index function result") and a new `FinalizeSecondaryKeyPrefix` method having the responsibility of dealing with serialization concerns like adding a length indicator for disambiguation. This also means a slight change for the `SecondaryIndexIterator` class: it now treats its `Seek` argument as an "index function result" and thus only calls the new `FinalizeSecondaryKeyPrefix` on it (but not `GetSecondaryKeyPrefix`). Differential Revision: D68514201
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
…es (#13324) Summary: Pull Request resolved: #13324 There are actually some use cases which would benefit from the ability to use the primary key when forming the secondary key prefix or value. One such use case, which is demonstrated using a unit test, is building a secondary index on non-initial part(s) of the primary key. The patch adds back this ability, which was was removed in #13207, with a twist: the earlier `GetSecondaryKeyPrefix` is essentially split into two parts, with `GetSecondaryKeyPrefix` now being responsible only for computing whatever the secondary index is built on (let's call this "index function result") and a new `FinalizeSecondaryKeyPrefix` method having the responsibility of dealing with serialization concerns like adding a length indicator for disambiguation. This also means a slight change for the `SecondaryIndexIterator` class: it now treats its `Seek` argument as an "index function result" and thus only calls the new `FinalizeSecondaryKeyPrefix` on it (but not `GetSecondaryKeyPrefix`). Reviewed By: jaykorean Differential Revision: D68514201 fbshipit-source-id: d3750d049b0aee37e6c20edc19f5e4a0d3fce91e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch tweaks the new
SecondaryIndexinterface a bit by removing theprimary_keyparameter ofGetSecondaryKeyPrefixandGetSecondaryValue. This parameter is currently unused by existing implementations and it actually does not make sense to have the secondary index prefix depend on the primary key since it would lead to potential chicken-and-egg problems at query time.Differential Revision: D67184936