Use incrementing numerical IDs to identify DOM components #5205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sophiebits
force-pushed
the
cotree-num
branch
from
629c736
to
d0e7fec
Compare
|
@spicyj updated the pull request. |
4 tasks
Initial render can still be a markup string.
New module! With this, we have a new module that uses the component tree to store DOM nodes. Most of the logic in this file relates to markup adoption -- if we were to drop that (along with server rendering) this file could just be a `return inst._nativeNode;`. This works with useCreateElement only because we need to reference each node as it's created. Events is now the only thing using ReactMount.getNode -- I'll introduce pointers back from the DOM nodes (and a `ReactDOMComponentTree.getInstanceFromNode`) and make that work.
sophiebits
force-pushed
the
cotree-num
branch
from
d0e7fec
to
a906911
Compare
|
@spicyj updated the pull request. |
|
Good luck! |
Next step: take advantage of having the native instances in EventPropagators instead of converting right back to IDs.
This removes SimpleEventPlugin's dependency on ReactMount.getID.
This test relied on the fact that ReactDOMComponent still produced hierarchical IDs -- although this module could be used standalone, we're replacing it completely so it makes more sense to just move the tests over to test ReactDOMTreeTraversal.
- Remove last references to ReactInstanceHandles (still used in responder unit test) - Remove ClientReactRootIndex/ServerReactRootIndex
sophiebits
force-pushed
the
cotree-num
branch
from
a906911
to
c193d1a
Compare
|
@spicyj updated the pull request. |
sophiebits
added a commit
that referenced
this pull request
Nov 4, 2015
Use incrementing numerical IDs to identify DOM components
|
Is there any way that this could cause problems when using an older version of React on the same page? |
|
Good question. I think this should probably be fine alongside 0.14 but didn't test. |
|
I'm wondering about 0.13.3 in particular. If I don't get an answer here I'll let you all know what I find when I dive in. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #5190. So... ignore the first 10 commits.