Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when duplicate copy of React #5441

Closed
jimfb opened this issue Nov 10, 2015 · 4 comments
Closed

Warn when duplicate copy of React #5441

jimfb opened this issue Nov 10, 2015 · 4 comments
Assignees
Milestone

Comments

@jimfb
Copy link
Contributor

jimfb commented Nov 10, 2015

Looks like we lost the duplicate-react warning (#3332) due to merging #5205 which contained sophiebits@4ba0e95

@jimfb jimfb added this to the 0.15 milestone Nov 10, 2015
@sophiebits
Copy link
Collaborator

Yes. That warning triggered in the case that deepestAncestor was null (which it should never be) but that codepath is gone now so it can't throw errors. If there's a new codepath that's problematic, feel free to add a new warning.

@sophiebits sophiebits assigned jimfb and unassigned sophiebits Nov 10, 2015
@jimfb
Copy link
Contributor Author

jimfb commented Nov 10, 2015

@spicyj But there are still other code paths, right? Events listeners, for instance?

@sophiebits
Copy link
Collaborator

If you know of any that cause problems where it's feasible for React to detect this, please add warnings. I don't know where they are, if they exist.

@jimfb
Copy link
Contributor Author

jimfb commented Nov 10, 2015

I suspect that there are cases, but I suppose we can create a new issue when one of them pops up.

@jimfb jimfb closed this as completed Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants