Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flags] Remove debugRenderPhaseSideEffectsForStrictMode #31839

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

rickhanlonii
Copy link
Member

This is enabled everywhere, we can just use the inline __DEV__ checks.

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 7:53pm

@react-sizebot
Copy link

react-sizebot commented Dec 18, 2024

Comparing: 74dd2da...95ccedd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.71 kB 510.71 kB = 91.29 kB 91.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 516.86 kB 516.86 kB = 92.24 kB 92.24 kB
facebook-www/ReactDOM-prod.classic.js = 592.42 kB 592.42 kB = 104.37 kB 104.37 kB
facebook-www/ReactDOM-prod.modern.js = 582.68 kB 582.68 kB = 102.82 kB 102.82 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/scheduler/cjs/Scheduler-prod.js = 10.18 kB 10.04 kB = 2.51 kB 2.46 kB

Generated by 🚫 dangerJS against a31bd58

@rickhanlonii rickhanlonii merged commit faf6c4d into facebook:main Dec 18, 2024
187 checks passed
@rickhanlonii rickhanlonii deleted the rh/rm-ff-render-sideeffects branch December 18, 2024 22:51
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
This is enabled everywhere, we can just use the inline `__DEV__` checks.

DiffTrain build for [faf6c4d](faf6c4d)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 19, 2024
This is enabled everywhere, we can just use the inline `__DEV__` checks.

DiffTrain build for [faf6c4d](facebook@faf6c4d)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 19, 2024
This is enabled everywhere, we can just use the inline `__DEV__` checks.

DiffTrain build for [faf6c4d](facebook@faf6c4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants