[flags] Remove debugRenderPhaseSideEffectsForStrictMode (facebook#31839)

This is enabled everywhere, we can just use the inline `__DEV__` checks. DiffTrain build for [faf6c4d](facebook@faf6c4d)
code · Dec 19, 2024 · 05d033a · 05d033a
1 parent fe2b70c
commit 05d033a
Show file tree

Hide file tree

Showing 34 changed files with 94 additions and 86 deletions.
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-e1d843f4d8776bbf5d4fbd12a39bcfd2c565f900
+faf6c4dfdcd3c9b3862af6a3afcb3d80abd407c0
diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
-e1d843f4d8776bbf5d4fbd12a39bcfd2c565f900
+faf6c4dfdcd3c9b3862af6a3afcb3d80abd407c0
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -1942,7 +1942,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+    exports.version = "19.1.0-www-classic-faf6c4df-20241218";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -1942,7 +1942,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.1.0-www-modern-e1d843f4-20241218";
+    exports.version = "19.1.0-www-modern-faf6c4df-20241218";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+exports.version = "19.1.0-www-classic-faf6c4df-20241218";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.1.0-www-modern-e1d843f4-20241218";
+exports.version = "19.1.0-www-modern-faf6c4df-20241218";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+exports.version = "19.1.0-www-classic-faf6c4df-20241218";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.1.0-www-modern-e1d843f4-20241218";
+exports.version = "19.1.0-www-modern-faf6c4df-20241218";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -16870,10 +16870,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.1.0-www-classic-e1d843f4-20241218",
+        version: "19.1.0-www-classic-faf6c4df-20241218",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.1.0-www-classic-e1d843f4-20241218"
+        reconcilerVersion: "19.1.0-www-classic-faf6c4df-20241218"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16907,7 +16907,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+    exports.version = "19.1.0-www-classic-faf6c4df-20241218";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -16633,10 +16633,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.1.0-www-modern-e1d843f4-20241218",
+        version: "19.1.0-www-modern-faf6c4df-20241218",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.1.0-www-modern-e1d843f4-20241218"
+        reconcilerVersion: "19.1.0-www-modern-faf6c4df-20241218"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16670,7 +16670,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.1.0-www-modern-e1d843f4-20241218";
+    exports.version = "19.1.0-www-modern-faf6c4df-20241218";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js
@@ -10757,10 +10757,10 @@ var slice = Array.prototype.slice,
   })(React.Component);
 var internals$jscomp$inline_1495 = {
   bundleType: 0,
-  version: "19.1.0-www-classic-e1d843f4-20241218",
+  version: "19.1.0-www-classic-faf6c4df-20241218",
   rendererPackageName: "react-art",
   currentDispatcherRef: ReactSharedInternals,
-  reconcilerVersion: "19.1.0-www-classic-e1d843f4-20241218"
+  reconcilerVersion: "19.1.0-www-classic-faf6c4df-20241218"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1496 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -10786,4 +10786,4 @@ exports.RadialGradient = RadialGradient;
 exports.Shape = TYPES.SHAPE;
 exports.Surface = Surface;
 exports.Text = Text;
-exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+exports.version = "19.1.0-www-classic-faf6c4df-20241218";
diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js
@@ -10473,10 +10473,10 @@ var slice = Array.prototype.slice,
   })(React.Component);
 var internals$jscomp$inline_1474 = {
   bundleType: 0,
-  version: "19.1.0-www-modern-e1d843f4-20241218",
+  version: "19.1.0-www-modern-faf6c4df-20241218",
   rendererPackageName: "react-art",
   currentDispatcherRef: ReactSharedInternals,
-  reconcilerVersion: "19.1.0-www-modern-e1d843f4-20241218"
+  reconcilerVersion: "19.1.0-www-modern-faf6c4df-20241218"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1475 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -10502,4 +10502,4 @@ exports.RadialGradient = RadialGradient;
 exports.Shape = TYPES.SHAPE;
 exports.Surface = Surface;
 exports.Text = Text;
-exports.version = "19.1.0-www-modern-e1d843f4-20241218";
+exports.version = "19.1.0-www-modern-faf6c4df-20241218";
diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -2502,6 +2502,8 @@ __DEV__ &&
             "hr" === tag ||
             "option" === tag ||
             "optgroup" === tag ||
+            "script" === tag ||
+            "template" === tag ||
             "#text" === tag
           );
         case "optgroup":
@@ -27345,11 +27347,11 @@ __DEV__ &&
       return_targetInst = null;
     (function () {
       var isomorphicReactPackageVersion = React.version;
-      if ("19.1.0-www-classic-e1d843f4-20241218" !== isomorphicReactPackageVersion)
+      if ("19.1.0-www-classic-faf6c4df-20241218" !== isomorphicReactPackageVersion)
         throw Error(
           'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n  - react:      ' +
             (isomorphicReactPackageVersion +
-              "\n  - react-dom:  19.1.0-www-classic-e1d843f4-20241218\nLearn more: https://react.dev/warnings/version-mismatch")
+              "\n  - react-dom:  19.1.0-www-classic-faf6c4df-20241218\nLearn more: https://react.dev/warnings/version-mismatch")
         );
     })();
     ("function" === typeof Map &&
@@ -27392,10 +27394,10 @@ __DEV__ &&
       !(function () {
         var internals = {
           bundleType: 1,
-          version: "19.1.0-www-classic-e1d843f4-20241218",
+          version: "19.1.0-www-classic-faf6c4df-20241218",
           rendererPackageName: "react-dom",
           currentDispatcherRef: ReactSharedInternals,
-          reconcilerVersion: "19.1.0-www-classic-e1d843f4-20241218"
+          reconcilerVersion: "19.1.0-www-classic-faf6c4df-20241218"
         };
         internals.overrideHookState = overrideHookState;
         internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27993,7 +27995,7 @@ __DEV__ &&
     exports.useFormStatus = function () {
       return resolveDispatcher().useHostTransitionStatus();
     };
-    exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+    exports.version = "19.1.0-www-classic-faf6c4df-20241218";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -2488,6 +2488,8 @@ __DEV__ &&
             "hr" === tag ||
             "option" === tag ||
             "optgroup" === tag ||
+            "script" === tag ||
+            "template" === tag ||
             "#text" === tag
           );
         case "optgroup":
@@ -27124,11 +27126,11 @@ __DEV__ &&
       return_targetInst = null;
     (function () {
       var isomorphicReactPackageVersion = React.version;
-      if ("19.1.0-www-modern-e1d843f4-20241218" !== isomorphicReactPackageVersion)
+      if ("19.1.0-www-modern-faf6c4df-20241218" !== isomorphicReactPackageVersion)
         throw Error(
           'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n  - react:      ' +
             (isomorphicReactPackageVersion +
-              "\n  - react-dom:  19.1.0-www-modern-e1d843f4-20241218\nLearn more: https://react.dev/warnings/version-mismatch")
+              "\n  - react-dom:  19.1.0-www-modern-faf6c4df-20241218\nLearn more: https://react.dev/warnings/version-mismatch")
         );
     })();
     ("function" === typeof Map &&
@@ -27171,10 +27173,10 @@ __DEV__ &&
       !(function () {
         var internals = {
           bundleType: 1,
-          version: "19.1.0-www-modern-e1d843f4-20241218",
+          version: "19.1.0-www-modern-faf6c4df-20241218",
           rendererPackageName: "react-dom",
           currentDispatcherRef: ReactSharedInternals,
-          reconcilerVersion: "19.1.0-www-modern-e1d843f4-20241218"
+          reconcilerVersion: "19.1.0-www-modern-faf6c4df-20241218"
         };
         internals.overrideHookState = overrideHookState;
         internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27772,7 +27774,7 @@ __DEV__ &&
     exports.useFormStatus = function () {
       return resolveDispatcher().useHostTransitionStatus();
     };
-    exports.version = "19.1.0-www-modern-e1d843f4-20241218";
+    exports.version = "19.1.0-www-modern-faf6c4df-20241218";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js
@@ -17221,14 +17221,14 @@ function getCrossOriginStringAs(as, input) {
 }
 var isomorphicReactPackageVersion$jscomp$inline_1767 = React.version;
 if (
-  "19.1.0-www-classic-e1d843f4-20241218" !==
+  "19.1.0-www-classic-faf6c4df-20241218" !==
   isomorphicReactPackageVersion$jscomp$inline_1767
 )
   throw Error(
     formatProdErrorMessage(
       527,
       isomorphicReactPackageVersion$jscomp$inline_1767,
-      "19.1.0-www-classic-e1d843f4-20241218"
+      "19.1.0-www-classic-faf6c4df-20241218"
     )
   );
 Internals.findDOMNode = function (componentOrElement) {
@@ -17246,10 +17246,10 @@ Internals.Events = [
 ];
 var internals$jscomp$inline_2301 = {
   bundleType: 0,
-  version: "19.1.0-www-classic-e1d843f4-20241218",
+  version: "19.1.0-www-classic-faf6c4df-20241218",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
-  reconcilerVersion: "19.1.0-www-classic-e1d843f4-20241218"
+  reconcilerVersion: "19.1.0-www-classic-faf6c4df-20241218"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2302 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17614,4 +17614,4 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+exports.version = "19.1.0-www-classic-faf6c4df-20241218";
diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js
@@ -16952,14 +16952,14 @@ function getCrossOriginStringAs(as, input) {
 }
 var isomorphicReactPackageVersion$jscomp$inline_1757 = React.version;
 if (
-  "19.1.0-www-modern-e1d843f4-20241218" !==
+  "19.1.0-www-modern-faf6c4df-20241218" !==
   isomorphicReactPackageVersion$jscomp$inline_1757
 )
   throw Error(
     formatProdErrorMessage(
       527,
       isomorphicReactPackageVersion$jscomp$inline_1757,
-      "19.1.0-www-modern-e1d843f4-20241218"
+      "19.1.0-www-modern-faf6c4df-20241218"
     )
   );
 Internals.findDOMNode = function (componentOrElement) {
@@ -16977,10 +16977,10 @@ Internals.Events = [
 ];
 var internals$jscomp$inline_2283 = {
   bundleType: 0,
-  version: "19.1.0-www-modern-e1d843f4-20241218",
+  version: "19.1.0-www-modern-faf6c4df-20241218",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
-  reconcilerVersion: "19.1.0-www-modern-e1d843f4-20241218"
+  reconcilerVersion: "19.1.0-www-modern-faf6c4df-20241218"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2284 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17345,4 +17345,4 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.1.0-www-modern-e1d843f4-20241218";
+exports.version = "19.1.0-www-modern-faf6c4df-20241218";
diff --git a/compiled/facebook-www/ReactDOM-profiling.classic.js b/compiled/facebook-www/ReactDOM-profiling.classic.js
@@ -17910,14 +17910,14 @@ function getCrossOriginStringAs(as, input) {
 }
 var isomorphicReactPackageVersion$jscomp$inline_1860 = React.version;
 if (
-  "19.1.0-www-classic-e1d843f4-20241218" !==
+  "19.1.0-www-classic-faf6c4df-20241218" !==
   isomorphicReactPackageVersion$jscomp$inline_1860
 )
   throw Error(
     formatProdErrorMessage(
       527,
       isomorphicReactPackageVersion$jscomp$inline_1860,
-      "19.1.0-www-classic-e1d843f4-20241218"
+      "19.1.0-www-classic-faf6c4df-20241218"
     )
   );
 Internals.findDOMNode = function (componentOrElement) {
@@ -17935,10 +17935,10 @@ Internals.Events = [
 ];
 var internals$jscomp$inline_1862 = {
   bundleType: 0,
-  version: "19.1.0-www-classic-e1d843f4-20241218",
+  version: "19.1.0-www-classic-faf6c4df-20241218",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
-  reconcilerVersion: "19.1.0-www-classic-e1d843f4-20241218"
+  reconcilerVersion: "19.1.0-www-classic-faf6c4df-20241218"
 };
 enableSchedulingProfiler &&
   ((internals$jscomp$inline_1862.getLaneLabelMap = getLaneLabelMap),
@@ -18306,7 +18306,7 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+exports.version = "19.1.0-www-classic-faf6c4df-20241218";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js
@@ -17640,14 +17640,14 @@ function getCrossOriginStringAs(as, input) {
 }
 var isomorphicReactPackageVersion$jscomp$inline_1850 = React.version;
 if (
-  "19.1.0-www-modern-e1d843f4-20241218" !==
+  "19.1.0-www-modern-faf6c4df-20241218" !==
   isomorphicReactPackageVersion$jscomp$inline_1850
 )
   throw Error(
     formatProdErrorMessage(
       527,
       isomorphicReactPackageVersion$jscomp$inline_1850,
-      "19.1.0-www-modern-e1d843f4-20241218"
+      "19.1.0-www-modern-faf6c4df-20241218"
     )
   );
 Internals.findDOMNode = function (componentOrElement) {
@@ -17665,10 +17665,10 @@ Internals.Events = [
 ];
 var internals$jscomp$inline_1852 = {
   bundleType: 0,
-  version: "19.1.0-www-modern-e1d843f4-20241218",
+  version: "19.1.0-www-modern-faf6c4df-20241218",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
-  reconcilerVersion: "19.1.0-www-modern-e1d843f4-20241218"
+  reconcilerVersion: "19.1.0-www-modern-faf6c4df-20241218"
 };
 enableSchedulingProfiler &&
   ((internals$jscomp$inline_1852.getLaneLabelMap = getLaneLabelMap),
@@ -18036,7 +18036,7 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.1.0-www-modern-e1d843f4-20241218";
+exports.version = "19.1.0-www-modern-faf6c4df-20241218";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactDOMServer-dev.classic.js b/compiled/facebook-www/ReactDOMServer-dev.classic.js
@@ -9150,5 +9150,5 @@ __DEV__ &&
         'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
       );
     };
-    exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+    exports.version = "19.1.0-www-classic-faf6c4df-20241218";
   })();
diff --git a/compiled/facebook-www/ReactDOMServer-dev.modern.js b/compiled/facebook-www/ReactDOMServer-dev.modern.js
@@ -8976,5 +8976,5 @@ __DEV__ &&
         'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
       );
     };
-    exports.version = "19.1.0-www-modern-e1d843f4-20241218";
+    exports.version = "19.1.0-www-modern-faf6c4df-20241218";
   })();
diff --git a/compiled/facebook-www/ReactDOMServer-prod.classic.js b/compiled/facebook-www/ReactDOMServer-prod.classic.js
@@ -5898,4 +5898,4 @@ exports.renderToString = function (children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "19.1.0-www-classic-e1d843f4-20241218";
+exports.version = "19.1.0-www-classic-faf6c4df-20241218";
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		e1d843f4d8776bbf5d4fbd12a39bcfd2c565f900
		faf6c4dfdcd3c9b3862af6a3afcb3d80abd407c0