Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on lazy context propagation for RN and RTR #31076

Merged

Conversation

jackpope
Copy link
Contributor

Following #30935 let's turn this on across the board so we can clean up experiments in RN.

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:23pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 26, 2024
@react-sizebot
Copy link

Comparing: b091ef7...aed2440

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 507.20 kB 507.20 kB = 90.80 kB 90.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.13 kB 512.13 kB = 91.52 kB 91.52 kB
facebook-www/ReactDOM-prod.classic.js = 603.73 kB 603.73 kB = 106.83 kB 106.83 kB
facebook-www/ReactDOM-prod.modern.js = 579.95 kB 579.95 kB = 102.92 kB 102.92 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.86% 321.66 kB 324.42 kB +0.80% 56.77 kB 57.23 kB
react-native/implementations/ReactFabric-prod.js +0.81% 348.82 kB 351.66 kB +0.70% 61.22 kB 61.65 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.81% 343.51 kB 346.28 kB +0.76% 59.82 kB 60.27 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.79% 358.49 kB 361.33 kB +0.72% 62.89 kB 63.34 kB
react-native/implementations/ReactFabric-profiling.js +0.76% 374.07 kB 376.92 kB +0.63% 64.88 kB 65.29 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.74% 383.73 kB 386.58 kB +0.77% 66.66 kB 67.17 kB
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.production.js +0.73% 304.07 kB 306.30 kB +0.77% 53.87 kB 54.28 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js +0.73% 304.07 kB 306.30 kB +0.77% 53.87 kB 54.28 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js +0.73% 304.14 kB 306.36 kB +0.77% 53.89 kB 54.31 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.54% 577.75 kB 580.85 kB +0.45% 94.33 kB 94.76 kB
react-native/implementations/ReactFabric-dev.js +0.51% 629.07 kB 632.27 kB +0.39% 103.22 kB 103.63 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.50% 640.11 kB 643.30 kB +0.39% 105.24 kB 105.65 kB
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.development.js +0.48% 544.61 kB 547.21 kB +0.46% 89.23 kB 89.63 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.48% 544.61 kB 547.21 kB +0.46% 89.23 kB 89.63 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.48% 544.68 kB 547.28 kB +0.46% 89.25 kB 89.66 kB
facebook-react-native/react/cjs/React-profiling.js = 19.15 kB 19.10 kB = 4.94 kB 4.91 kB
facebook-react-native/react/cjs/React-prod.js = 18.71 kB 18.67 kB = 4.86 kB 4.83 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js = 992.16 kB 986.69 kB = 167.52 kB 166.98 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js = 975.82 kB 970.35 kB = 164.69 kB 164.15 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 666.68 kB 661.19 kB = 109.45 kB 108.81 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js = 565.27 kB 560.61 kB = 99.93 kB 99.46 kB
react-native/implementations/ReactFabric-dev.fb.js = 659.65 kB 654.17 kB = 107.97 kB 107.36 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js = 559.33 kB 554.67 kB = 98.78 kB 98.31 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js = 539.90 kB 535.25 kB = 96.09 kB 95.56 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js = 534.39 kB 529.74 kB = 95.01 kB 94.49 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 410.75 kB 405.95 kB = 71.28 kB 70.74 kB
react-native/implementations/ReactFabric-profiling.fb.js = 405.12 kB 400.31 kB = 70.17 kB 69.58 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 385.20 kB 380.42 kB = 67.47 kB 66.88 kB
react-native/implementations/ReactFabric-prod.fb.js = 379.54 kB 374.76 kB = 66.28 kB 65.73 kB

Generated by 🚫 dangerJS against 3636c02

@jackpope jackpope merged commit 60b1420 into facebook:main Sep 26, 2024
184 checks passed
@jackpope jackpope deleted the enable-lazy-context-propagation-everywhere branch September 26, 2024 16:55
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
Following #30935 let's turn this
on across the board so we can clean up experiments in RN.

DiffTrain build for [60b1420](60b1420)
gnoff added a commit to vercel/next.js that referenced this pull request Sep 27, 2024
abhi12299 pushed a commit to abhi12299/next.js that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants