Add: reload to profile for Fusebox #31021

EdmondChuiHW · 2024-09-22T16:09:00Z

Summary

Add reload to profile for Fusebox

Stacked on #31048. See 6be1977

How did you test this change?

vercel · 2024-09-22T16:09:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 26, 2024 3:43pm

EdmondChuiHW · 2024-09-22T16:30:12Z

packages/react-devtools-shared/src/devtools/ProfilerStore.js

+    if (this._isProfiling === isProfiling) {
+      return;
+    }
+


There are existing crashes reported on web:

#30661
#28838

Adding support for Fusebox in the PR encountered similar crashes.

These lines fix it for Fusebox; it could be the fix for web as well.

That's because onProfilingStatus is called repeatedly on some occasions, e.g. multiple calls to getProfilingStatus

## Summary Profiling fails sometimes because `onProfilingStatus` is called repeatedly on some occasions, e.g. multiple calls to `getProfilingStatus`. Subsequent calls should be a no-op if the profiling status hasn't changed. Reported via #30661 #28838. > [!TIP] > Hide whitespace changes on this PR <img width="328" alt="screenshot showing the UI controls for hiding whitespace changes on GitHub" src="https://github.com/user-attachments/assets/036385cf-2610-4e69-a717-17c05d7ef047"> ## How did you test this change?  Tested as part of Fusebox implementation of reload-to-profile. #31021

#31048)  ## Summary In preparation to support reload-to-profile in Fusebox (#31021), we need a way to check capability of different backends, e.g. web vs React Native. ## How did you test this change?  * Default, e.g. existing web impl = no-op * Custom impl: is called

packages/react-devtools-shared/src/attachRenderer.js

hoxyq · 2024-09-26T14:17:19Z

packages/react-devtools-core/src/backend.js

@@ -60,6 +63,7 @@ export function initialize(
  maybeSettingsOrSettingsPromise?:
    | DevToolsHookSettings
    | Promise<DevToolsHookSettings>,
+  reloadAndProfileConfig: ReloadAndProfileConfig,


looks like this is unused

This is passed in from setUpReactDevTools.js https://www.internalfb.com/diff/D63233256?permalink=3800761013473689

Yeah, but this is unused in this function.

You are passing this in connectToDevTools and in connectWithCustomMessagingProtocol, and you are using it there

We're using it in all three places. initialize needs the initial (heh) boolean values to pass onto renderer, and the connect* functions need the full *ConfigPersistence to read & write the flags

Edit: LOL I see what you mean now 🤦‍♂️ Thanks for the permalink.

react/packages/react-devtools-core/src/backend.js

Lines 62 to 69 in ba97e6e

export function initialize(

maybeSettingsOrSettingsPromise?:

| DevToolsHookSettings

| Promise<DevToolsHookSettings>,

reloadAndProfileConfig: ReloadAndProfileConfig,

) {

installHook(window, maybeSettingsOrSettingsPromise);

}

It got messed up during rebase. Fixed now

Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under new architecture. Bridging for legacy Android and iOS will be added in follow-up diffs Differential Revision: D63233256

Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Differential Revision: D63233256

Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256

Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256

…6856) Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256

Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256

Summary: Pull Request resolved: #46856 Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256 fbshipit-source-id: f2f2814491e785b03af143cc26639ef178881fff

Changes in this release: * Fix React Compiler badging ([poteto](https://github.com/poteto) in [#31196](#31196)) * fix[react-devtools]: fixed timeline profiler tests ([hoxyq](https://github.com/hoxyq) in [#31261](#31261)) * fix[react-devtools]: record timeline data only when supported ([hoxyq](https://github.com/hoxyq) in [#31154](#31154)) * refactor[react-devtools]: flatten reload and profile config ([hoxyq](https://github.com/hoxyq) in [#31132](#31132)) * fix[react-devtools]: remove all listeners when Agent is shutdown ([hoxyq](https://github.com/hoxyq) in [#31151](#31151)) * fix[react-devtools]: removed redundant startProfiling call ([hoxyq](https://github.com/hoxyq) in [#31131](#31131)) * refactor[react-devtools/fiber/renderer]: optimize durations resolution ([hoxyq](https://github.com/hoxyq) in [#31118](#31118)) * fix[react-devtools]: update profiling status before receiving response from backend ([hoxyq](https://github.com/hoxyq) in [#31117](#31117)) * fix[react-devtools]: wrap key string in preformatted text html element ([hoxyq](https://github.com/hoxyq) in [#31153](#31153)) * chore[react-devtools]: drop legacy context tests ([hoxyq](https://github.com/hoxyq) in [#31059](#31059)) * chore[react-devtools]: add legacy mode error message to the ignore list for tests ([hoxyq](https://github.com/hoxyq) in [#31060](#31060)) * fix[react-devtools]: request hook initialization inside http server response ([hoxyq](https://github.com/hoxyq) in [#31102](#31102)) * [Flight] Serialize Server Components Props in DEV ([sebmarkbage](https://github.com/sebmarkbage) in [#31105](#31105)) * Add: reload to profile for Fusebox ([EdmondChuiHW](https://github.com/EdmondChuiHW) in [#31021](#31021)) * refactor: allow custom impl of backend realod-to-profile support check ([EdmondChuiHW](https://github.com/EdmondChuiHW) in [#31048](#31048)) * fix: use public instance in Fiber renderer and expose it from getInspectorDataForViewAtPoint ([hoxyq](https://github.com/hoxyq) in [#31068](#31068))

facebook-github-bot added the CLA Signed label Sep 22, 2024

EdmondChuiHW mentioned this pull request Sep 22, 2024

Add reload-to-profile for Fusebox facebookexperimental/rn-chrome-devtools-frontend#117

Merged

2 tasks

vercel bot deployed to Preview September 22, 2024 16:11 View deployment

EdmondChuiHW commented Sep 22, 2024

View reviewed changes

EdmondChuiHW mentioned this pull request Sep 23, 2024

Fix: profiling crashes #30661 #28838 #31024

Merged

EdmondChuiHW mentioned this pull request Sep 24, 2024

refactor: allow custom impl of backend realod-to-profile support check #31048

Merged

EdmondChuiHW force-pushed the reload2profile-fusebox branch from daba3d8 to 4d2b22a Compare September 25, 2024 15:41

vercel bot deployed to Preview September 25, 2024 15:46 View deployment

EdmondChuiHW force-pushed the reload2profile-fusebox branch from 4d2b22a to 4e24fb6 Compare September 25, 2024 16:28

vercel bot deployed to Preview September 25, 2024 16:31 View deployment

EdmondChuiHW requested a review from hoxyq September 26, 2024 03:03

EdmondChuiHW force-pushed the reload2profile-fusebox branch 2 times, most recently from 6be1977 to d8da2b9 Compare September 26, 2024 03:16

EdmondChuiHW marked this pull request as ready for review September 26, 2024 03:16

vercel bot deployed to Preview September 26, 2024 03:18 View deployment

EdmondChuiHW force-pushed the reload2profile-fusebox branch from d8da2b9 to 78a15f4 Compare September 26, 2024 10:31

vercel bot deployed to Preview September 26, 2024 10:37 View deployment

EdmondChuiHW marked this pull request as draft September 26, 2024 11:43

EdmondChuiHW force-pushed the reload2profile-fusebox branch from 78a15f4 to 0dfe075 Compare September 26, 2024 12:44

EdmondChuiHW marked this pull request as ready for review September 26, 2024 12:46

vercel bot deployed to Preview September 26, 2024 12:46 View deployment

hoxyq reviewed Sep 26, 2024

View reviewed changes

EdmondChuiHW force-pushed the reload2profile-fusebox branch from 0dfe075 to ba97e6e Compare September 26, 2024 14:27

EdmondChuiHW requested a review from hoxyq September 26, 2024 14:27

vercel bot deployed to Preview September 26, 2024 14:30 View deployment

hoxyq approved these changes Sep 26, 2024

View reviewed changes

Add: reload to profile for Fusebox

feace7e

EdmondChuiHW force-pushed the reload2profile-fusebox branch from ba97e6e to feace7e Compare September 26, 2024 15:37

EdmondChuiHW merged commit 204a551 into facebook:main Sep 26, 2024
158 of 159 checks passed

EdmondChuiHW deleted the reload2profile-fusebox branch September 26, 2024 15:39

vercel bot deployed to Preview September 26, 2024 15:43 View deployment

EdmondChuiHW mentioned this pull request Oct 6, 2024

Fusebox reload-to-profile facebook/react-native#46856

Closed

hoxyq mentioned this pull request Oct 15, 2024

React DevTools 6.0.0 -> 6.0.1 #31263

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add: reload to profile for Fusebox #31021

Add: reload to profile for Fusebox #31021

EdmondChuiHW commented Sep 22, 2024 •

edited

Loading

vercel bot commented Sep 22, 2024 •

edited

Loading

EdmondChuiHW Sep 22, 2024 •

edited

Loading

hoxyq Sep 26, 2024

EdmondChuiHW Sep 26, 2024

hoxyq Sep 26, 2024

EdmondChuiHW Sep 26, 2024 •

edited

Loading

	export function initialize(
	maybeSettingsOrSettingsPromise?:
	\| DevToolsHookSettings
	\| Promise<DevToolsHookSettings>,
	reloadAndProfileConfig: ReloadAndProfileConfig,
	) {
	installHook(window, maybeSettingsOrSettingsPromise);
	}

Add: reload to profile for Fusebox #31021

Add: reload to profile for Fusebox #31021

Conversation

EdmondChuiHW commented Sep 22, 2024 • edited Loading

Summary

How did you test this change?

vercel bot commented Sep 22, 2024 • edited Loading

EdmondChuiHW Sep 22, 2024 • edited Loading

Choose a reason for hiding this comment

hoxyq Sep 26, 2024

Choose a reason for hiding this comment

EdmondChuiHW Sep 26, 2024

Choose a reason for hiding this comment

hoxyq Sep 26, 2024

Choose a reason for hiding this comment

EdmondChuiHW Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

EdmondChuiHW commented Sep 22, 2024 •

edited

Loading

vercel bot commented Sep 22, 2024 •

edited

Loading

EdmondChuiHW Sep 22, 2024 •

edited

Loading

EdmondChuiHW Sep 26, 2024 •

edited

Loading