[compiler] Don't error on ref-in-render on StartMemoize #30715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: Fixes the previous issue: ref enforcement ignores memoization marker instructions [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Aug 15, 2024
Test Plan: Fixes the previous issue: ref enforcement ignores memoization marker instructions [ghstack-poisoned]
josephsavona
approved these changes
Aug 15, 2024
| ``` | ||
|
|
||
| ### Eval output | ||
| (kind: exception) useRef is not defined |
Test Plan: Fixes the previous issue: ref enforcement ignores memoization marker instructions [ghstack-poisoned]
This was referenced Aug 16, 2024
Test Plan: Fixes the previous issue: ref enforcement ignores memoization marker instructions [ghstack-poisoned]
Test Plan: Fixes the previous issue: ref enforcement ignores memoization marker instructions [ghstack-poisoned]
mvitousek
added a commit
that referenced
this pull request
Aug 16, 2024
Test Plan: Fixes the previous issue: ref enforcement ignores memoization marker instructions ghstack-source-id: f35d6a611c5e740e9ea354ec80c3d7cdb3c0d658 Pull Request resolved: #30715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions