Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Don't error on ref-in-render on StartMemoize #30715

Merged
merged 5 commits into from
Aug 16, 2024
Merged

[compiler] Don't error on ref-in-render on StartMemoize #30715

merged 5 commits into from
Aug 16, 2024

Commits on Aug 15, 2024

  1. [compiler] Don't error on ref-in-render on StartMemoize 

    Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ab668d5 View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler] Don't error on ref-in-render on StartMemoize" 

    Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4de184f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Update on "[compiler] Don't error on ref-in-render on StartMemoize" 

    Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2de6015 View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler] Don't error on ref-in-render on StartMemoize" 

    Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0ce4742 View commit details
    Browse the repository at this point in the history

  3. Update on "[compiler] Don't error on ref-in-render on StartMemoize" 

    Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ce0887f View commit details
    Browse the repository at this point in the history