Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fax] Rename renderToMarkup to renderToHTML #30689

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Aug 14, 2024

Summary

Gives us the option to render different formats in the future.

How did you test this change?

  • CI

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 5:30pm

@react-sizebot
Copy link

react-sizebot commented Aug 14, 2024

Comparing: e0a0e65...8608c3b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8a5e4b7

@eps1lon eps1lon marked this pull request as ready for review August 14, 2024 17:23
@eps1lon eps1lon force-pushed the sebbie/react-markup/renderToHTML branch from 3b6d41d to 8a5e4b7 Compare August 14, 2024 17:24
@eps1lon eps1lon merged commit 5c9243d into main Aug 14, 2024
185 checks passed
@eps1lon eps1lon deleted the sebbie/react-markup/renderToHTML branch August 14, 2024 17:35
@eps1lon eps1lon changed the title Rename renderToMarkup to renderToHTML [Fax] Rename renderToMarkup to renderToHTML Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants