[Fax] Publish experimental_renderToHTML
#30690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
force-pushed
the
sebbie/react-markup/s2
branch
from
1ea59a4
to
23d0254
Compare
|
Comparing: 5c9243d...79b705b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
force-pushed
the
sebbie/react-markup/s2
branch
from
350b1f3
to
6fd10f3
Compare
eps1lon
commented
Aug 14, 2024
| @@ -130,8 +135,20 @@ if (!__EXPERIMENTAL__) { | |||
| } | |||
|
|
|||
| await expect(async () => { | |||
| await ReactHTML.renderToMarkup(React.createElement(Component)); | |||
| }).rejects.toThrow(); | |||
There was a problem hiding this comment.
Test would've passed without renaming so I added the exact message we expect.
eps1lon
force-pushed
the
sebbie/react-markup/s2
branch
from
6fd10f3
to
f7ccf0b
Compare
eps1lon
force-pushed
the
sebbie/react-markup/s2
branch
from
062f774
to
29b5f33
Compare
sebmarkbage
approved these changes
Aug 14, 2024
eps1lon
changed the title
experimental_renderToHTMLexperimental_renderToHTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to get greenlight from @rickhanlonii first that the bot get the maintainer invitationreact-bot has publish rights.Summary
Publishes
react-markup@experimentalrenderToHTMLis experimental so it should be published with the prefix.Reference docs: reactjs/react.dev#7107
How did you test this change?