Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Allow aborting during render #29764

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[Flight] Allow aborting during render #29764

merged 1 commit into from
Jun 6, 2024

Commits on Jun 6, 2024

  1. [Flight] Allow aborting during render 

    Previously if you aborted during a render the currently rendering task would itself be aborted which will cause the entire model to be replaced by the aborted error rather than just the slot currently being rendered.

This change updates the abort logic to mark currently rendering tasks as aborted but allowing the current render to emit a partially serialized model with an error reference in place of the current model.

The intent is to support aborting from rendering synchronously, in microtasks (after an await or in a .then) and in lazy initializers. We don't specifically support aborting from things like proxies that might be triggered during serialization of props
    @gnoff
    gnoff committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    67157af View commit details
    Browse the repository at this point in the history