[Flight] Allow aborting during render #29764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
force-pushed
the
allow-aborting-while-rendering
branch
from
e7be19d
to
7849a51
Compare
gnoff
force-pushed
the
allow-aborting-while-rendering
branch
from
7849a51
to
8ed7a66
Compare
gnoff
force-pushed
the
allow-aborting-while-rendering
branch
from
8ed7a66
to
f4b7800
Compare
gnoff
force-pushed
the
allow-aborting-while-rendering
branch
from
f4b7800
to
5da3e35
Compare
gnoff
force-pushed
the
allow-aborting-while-rendering
branch
2 times, most recently
from
8ea2591
to
b98f9e4
Compare
gnoff
force-pushed
the
allow-aborting-while-rendering
branch
from
b98f9e4
to
d273963
Compare
gnoff
force-pushed
the
allow-aborting-while-rendering
branch
from
d273963
to
d4174f2
Compare
gnoff
force-pushed
the
allow-aborting-while-rendering
branch
from
d4174f2
to
078beb5
Compare
Previously if you aborted during a render the currently rendering task would itself be aborted which will cause the entire model to be replaced by the aborted error rather than just the slot currently being rendered. This change updates the abort logic to mark currently rendering tasks as aborted but allowing the current render to emit a partially serialized model with an error reference in place of the current model. The intent is to support aborting from rendering synchronously, in microtasks (after an await or in a .then) and in lazy initializers. We don't specifically support aborting from things like proxies that might be triggered during serialization of props
gnoff
force-pushed
the
allow-aborting-while-rendering
branch
from
078beb5
to
67157af
Compare
sebmarkbage
approved these changes
Jun 6, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
Stacked on #29491 Previously if you aborted during a render the currently rendering task would itself be aborted which will cause the entire model to be replaced by the aborted error rather than just the slot currently being rendered. This change updates the abort logic to mark currently rendering tasks as aborted but allowing the current render to emit a partially serialized model with an error reference in place of the current model. The intent is to support aborting from rendering synchronously, in microtasks (after an await or in a .then) and in lazy initializers. We don't specifically support aborting from things like proxies that might be triggered during serialization of props DiffTrain build for commit c4b433f.
gnoff
added a commit
to gnoff/react
that referenced
this pull request
Jul 26, 2024
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in facebook#29764
gnoff
added a commit
to gnoff/react
that referenced
this pull request
Jul 26, 2024
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in facebook#29764
gnoff
added a commit
to gnoff/react
that referenced
this pull request
Jul 29, 2024
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in facebook#29764
gnoff
added a commit
to gnoff/react
that referenced
this pull request
Jul 29, 2024
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in facebook#29764
gnoff
added a commit
to gnoff/react
that referenced
this pull request
Jul 29, 2024
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in facebook#29764
gnoff
added a commit
that referenced
this pull request
Jul 29, 2024
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in #29764
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in #29764 DiffTrain build for [a451de0](a451de0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #29491
Previously if you aborted during a render the currently rendering task would itself be aborted which will cause the entire model to be replaced by the aborted error rather than just the slot currently being rendered.
This change updates the abort logic to mark currently rendering tasks as aborted but allowing the current render to emit a partially serialized model with an error reference in place of the current model.
The intent is to support aborting from rendering synchronously, in microtasks (after an await or in a .then) and in lazy initializers. We don't specifically support aborting from things like proxies that might be triggered during serialization of props