Convert ReactDOMTestSelectors-test.js to createRoot #27993

rickhanlonii · 2024-01-18T22:08:37Z

Straightforward adding createRoot and act

rickhanlonii · 2024-01-18T22:08:53Z

packages/react-dom/src/__tests__/ReactDOMTestSelectors-test.js

@@ -31,7 +31,8 @@ describe('ReactDOMTestSelectors', () => {
    jest.resetModules();

    React = require('react');
-    act = React.unstable_act;
+    createRoot = require('react-dom/client').createRoot;
+    act = require('internal-test-utils').act;


Switch to internal act

rickhanlonii · 2024-01-18T22:09:12Z

packages/react-dom/src/__tests__/ReactDOMTestSelectors-test.js

@@ -1389,7 +1493,7 @@ No matching component was found for:
        {rect: rect1, ratio: 1},
      ]);

-      act(() => increment());
+      await act(() => increment());


Need to await act now

rickhanlonii · 2024-01-18T22:09:17Z

packages/react-dom/src/__tests__/ReactDOMTestSelectors-test.js

@@ -1412,7 +1516,7 @@ No matching component was found for:
        {rect: rect2, ratio: 0.25},
      ]);

-      act(() => increment());
+      await act(() => increment());


Need to await act now

react-sizebot · 2024-01-18T22:16:09Z

Comparing: 1d5667a...0fe7627

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	175.90 kB	175.90 kB	=	54.76 kB	54.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	177.97 kB	177.97 kB	=	55.39 kB	55.39 kB
facebook-www/ReactDOM-prod.classic.js	=	570.21 kB	570.21 kB	=	100.35 kB	100.35 kB
facebook-www/ReactDOM-prod.modern.js	=	554.06 kB	554.06 kB	=	97.43 kB	97.43 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 0fe7627

kassens

Thanks!

kassens · 2024-01-18T22:29:55Z

Actually looks like some test failures that need to be fixed before merging.

rickhanlonii · 2024-01-18T22:51:26Z

Damn I thought i could sneak the failures by you

rickhanlonii · 2024-01-24T03:51:59Z

packages/react-dom/unstable_testing.js

+  version,
+} from './index.js';
+
+export {createRoot, hydrateRoot} from './client.js';


Heads up @gnoff, I needed to update the imports in the unstable_testing entrypoints so using create/hydrateRoot doesn't error. Let me know if there are any concerns, but I think this is what we want to do, at least while this is unstable.

Straightforward adding createRoot and act DiffTrain build for [4217d32](4217d32)

Straightforward adding createRoot and act

Straightforward adding createRoot and act DiffTrain build for commit 4217d32.

Convert ReactDOMTestSelectors-test.js to createRoot

7c76858

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 18, 2024

rickhanlonii commented Jan 18, 2024

View reviewed changes

kassens approved these changes Jan 18, 2024

View reviewed changes

rickhanlonii added 2 commits January 23, 2024 22:16

Use correct createRoot in unstable_testing.js

9e00aaa

uwu

0fe7627

rickhanlonii commented Jan 24, 2024

View reviewed changes

rickhanlonii merged commit 4217d32 into facebook:main Jan 24, 2024
36 checks passed

github-actions bot pushed a commit that referenced this pull request Jan 24, 2024

Convert ReactDOMTestSelectors-test.js to createRoot (#27993)

605ae6d

Straightforward adding createRoot and act DiffTrain build for [4217d32](4217d32)

rickhanlonii deleted the rh/tests-dom-selectors branch January 24, 2024 04:28

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Convert ReactDOMTestSelectors-test.js to createRoot (facebook#27993)

50bba42

Straightforward adding createRoot and act

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Convert ReactDOMTestSelectors-test.js to createRoot (#27993)

b9f5238

Straightforward adding createRoot and act DiffTrain build for commit 4217d32.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert ReactDOMTestSelectors-test.js to createRoot #27993

Convert ReactDOMTestSelectors-test.js to createRoot #27993

rickhanlonii commented Jan 18, 2024

rickhanlonii Jan 18, 2024

rickhanlonii Jan 18, 2024

rickhanlonii Jan 18, 2024

react-sizebot commented Jan 18, 2024 •

edited

Loading

kassens left a comment

kassens commented Jan 18, 2024

rickhanlonii commented Jan 18, 2024

rickhanlonii Jan 24, 2024

Convert ReactDOMTestSelectors-test.js to createRoot #27993

Convert ReactDOMTestSelectors-test.js to createRoot #27993

Conversation

rickhanlonii commented Jan 18, 2024

rickhanlonii Jan 18, 2024

Choose a reason for hiding this comment

rickhanlonii Jan 18, 2024

Choose a reason for hiding this comment

rickhanlonii Jan 18, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 18, 2024 • edited Loading

Critical size changes

Significant size changes

kassens left a comment

Choose a reason for hiding this comment

kassens commented Jan 18, 2024

rickhanlonii commented Jan 18, 2024

rickhanlonii Jan 24, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 18, 2024 •

edited

Loading