Refactor React Server entrypoint to not depend on the client one #27940

acdlite · 2024-01-15T17:41:44Z

This refactors the Server Components entrypoint for the react package (ReactServer.js) so that it doesn't depend on the client entrypoint (React.js). I also renamed React.js to ReactClient.js to make the separation clearer.

This structure will make it easier to add client-only and server-only features.

react-sizebot · 2024-01-15T17:46:48Z

Comparing: 5d1b15a...7570348

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.19 kB	176.19 kB	=	54.88 kB	54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.29 kB	178.29 kB	=	55.53 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	571.89 kB	571.89 kB	=	100.56 kB	100.56 kB
facebook-www/ReactDOM-prod.modern.js	=	555.65 kB	555.65 kB	=	97.63 kB	97.63 kB
oss-experimental/react/cjs/react.react-server.production.min.js	=	9.99 kB	9.25 kB	=	3.98 kB	3.76 kB
facebook-www/ReactServer-dev.modern.js	=	116.83 kB	107.94 kB	=	26.58 kB	26.22 kB
oss-experimental/react/cjs/react.react-server.development.js	=	94.13 kB	86.36 kB	=	26.14 kB	23.98 kB
facebook-www/ReactServer-prod.modern.js	=	15.53 kB	14.17 kB	=	4.13 kB	3.83 kB
oss-stable/react/cjs/react.react-server.development.js	=	85.03 kB	77.24 kB	=	23.61 kB	21.36 kB
oss-stable-semver/react/cjs/react.react-server.development.js	=	85.00 kB	77.21 kB	=	23.58 kB	21.33 kB
oss-stable/react/cjs/react.react-server.production.min.js	=	7.44 kB	6.75 kB	=	3.14 kB	2.92 kB
oss-stable-semver/react/cjs/react.react-server.production.min.js	=	7.41 kB	6.72 kB	=	3.11 kB	2.89 kB
oss-experimental/react/cjs/react.react-server.production.js	=	42.04 kB	36.27 kB	=	12.11 kB	10.69 kB
oss-stable/react/cjs/react.react-server.production.js	=	34.01 kB	28.29 kB	=	9.94 kB	8.53 kB
oss-stable-semver/react/cjs/react.react-server.production.js	=	33.99 kB	28.26 kB	=	9.91 kB	8.50 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-experimental/react/cjs/react.react-server.production.min.js	=	9.99 kB	9.25 kB	=	3.98 kB	3.76 kB
facebook-www/ReactServer-dev.modern.js	=	116.83 kB	107.94 kB	=	26.58 kB	26.22 kB
oss-experimental/react/cjs/react.react-server.development.js	=	94.13 kB	86.36 kB	=	26.14 kB	23.98 kB
facebook-www/ReactServer-prod.modern.js	=	15.53 kB	14.17 kB	=	4.13 kB	3.83 kB
oss-stable/react/cjs/react.react-server.development.js	=	85.03 kB	77.24 kB	=	23.61 kB	21.36 kB
oss-stable-semver/react/cjs/react.react-server.development.js	=	85.00 kB	77.21 kB	=	23.58 kB	21.33 kB
oss-stable/react/cjs/react.react-server.production.min.js	=	7.44 kB	6.75 kB	=	3.14 kB	2.92 kB
oss-stable-semver/react/cjs/react.react-server.production.min.js	=	7.41 kB	6.72 kB	=	3.11 kB	2.89 kB
oss-experimental/react/cjs/react.react-server.production.js	=	42.04 kB	36.27 kB	=	12.11 kB	10.69 kB
oss-stable/react/cjs/react.react-server.production.js	=	34.01 kB	28.29 kB	=	9.94 kB	8.53 kB
oss-stable-semver/react/cjs/react.react-server.production.js	=	33.99 kB	28.26 kB	=	9.91 kB	8.50 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 7570348

gnoff

but check my comments on the server rename PR. think we want to adjust it slightly

The implementation of createElement is different in production and development. This moves the DEV check out of the entry module and into the ReactElement module. There was already a TODO comment for this; I'm doing it now because I'm about to refactor the server entry module (ReactServer.js) to import createElement directly instead of going through the client entry module (React.js, which I'll also probably rename to ReactClient.js).

This refactors the Server Components entrypoint for the `react` package (ReactServer.js) so that it doesn't depend on the client entrypoint (React.js). In the next step, I'll also rename React.js to ReactClient.js to make the separation clearer. This structure will make it easier to add client-only and server- only features.

The server entrypoint no longer depends on this module. It's now only imported by the client. I've updated the name to reflect that it's client-only, and can include client-only features.

) This refactors the Server Components entrypoint for the `react` package (ReactServer.js) so that it doesn't depend on the client entrypoint (React.js). I also renamed React.js to ReactClient.js to make the separation clearer. This structure will make it easier to add client-only and server-only features. DiffTrain build for [f16344e](f16344e)

…ebook#27940) This refactors the Server Components entrypoint for the `react` package (ReactServer.js) so that it doesn't depend on the client entrypoint (React.js). I also renamed React.js to ReactClient.js to make the separation clearer. This structure will make it easier to add client-only and server-only features.

) This refactors the Server Components entrypoint for the `react` package (ReactServer.js) so that it doesn't depend on the client entrypoint (React.js). I also renamed React.js to ReactClient.js to make the separation clearer. This structure will make it easier to add client-only and server-only features. DiffTrain build for commit f16344e.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 15, 2024

acdlite marked this pull request as ready for review January 15, 2024 17:45

acdlite requested review from sebmarkbage and gnoff January 15, 2024 17:45

acdlite mentioned this pull request Jan 16, 2024

Remove client caching from cache() API #27977

Merged

gnoff approved these changes Jan 16, 2024

View reviewed changes

acdlite added 3 commits January 16, 2024 19:58

Rename React.js entrypoint to ReactClient.js

7570348

The server entrypoint no longer depends on this module. It's now only imported by the client. I've updated the name to reflect that it's client-only, and can include client-only features.

acdlite force-pushed the split-client-and-server-entrypoints branch from 7d85475 to 7570348 Compare January 17, 2024 01:00

acdlite merged commit f16344e into facebook:main Jan 17, 2024
36 checks passed

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor React Server entrypoint to not depend on the client one #27940

Refactor React Server entrypoint to not depend on the client one #27940

acdlite commented Jan 15, 2024 •

edited

Loading

react-sizebot commented Jan 15, 2024 •

edited

Loading

gnoff left a comment

Refactor React Server entrypoint to not depend on the client one #27940

Refactor React Server entrypoint to not depend on the client one #27940

Conversation

acdlite commented Jan 15, 2024 • edited Loading

react-sizebot commented Jan 15, 2024 • edited Loading

Critical size changes

Significant size changes

gnoff left a comment

Choose a reason for hiding this comment

acdlite commented Jan 15, 2024 •

edited

Loading

react-sizebot commented Jan 15, 2024 •

edited

Loading