Move some files out of /shared and rename to upper case #18363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
requested review from
bvaughn,
gaearon,
trueadm,
lunaruan and
acdlite
facebook-github-bot
added
CLA Signed
React Core Team
…med exports We're somewhat inconsistent here between e.g. ReactLazy and memo. Let's pick one. This also moves the responder, fundamental, scope creators from shared since they're isomorphic and same as the other creators.
Individual renderers are allowed to deep require into the reconciler.
react-interactions is right now dom specific (it wasn't before) so we can type check it together with other dom stuff. Avoids the need for a shared ReactDOMTypes to be checked by RN for example.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c581aa3:
|
Details of bundled changes.Comparing: a600408...c581aa3 react-noop-renderer
react-reconciler
Size changes (stable) |
Details of bundled changes.Comparing: a600408...c581aa3 react-noop-renderer
react-reconciler
Size changes (experimental) |
Otherwise Noop can't access it since it's not allowed deep requires.
|
I believe the RN sync script pulls some bits out of shared, so we should make sure that those bits still work. However, it might only be |
|
Yea it's only ReactTypes and ReactNativeTypes. However, I'll separately open a diff to stop syncing ReactTypes. We shouldn't be using that in RN because it's not consistent with the upstream Flow types. That causes issues and all current imports were incorrect and has been codemodded so they're now unused. |
gaearon
approved these changes
Mar 21, 2020
trueadm
approved these changes
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some stuff out of shared and into their respective packages.
I changed the isomorphic "creator" types to use the same convention (upper case) with named exports. It was inconsistent before.
Things that are Fiber specific can live in the reconciler because any individual renderer is allowed to deep link into react-reconciler. At least ours are.