-
Notifications
You must be signed in to change notification settings - Fork 47.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary lines for hasBadMapPolyfill
issue for rollup
#16231
Remove unnecessary lines for hasBadMapPolyfill
issue for rollup
#16231
Conversation
Details of bundled changes.Comparing: 75ab53b...02382a1 react
react-native-renderer
Generated by 🚫 dangerJS |
The build was failing because of the rollup version upgrade so I revert back to the version it was before. Interestingly, all tests are passing. Apparently It was already fixed in the current version. 🤔 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
I do not think this is stale but it depends on finally updating to the latest Rollup version, i.e. merging #15037. Then this change is a no-brainer. |
We bumped the version. Mind rebasing? |
Sure. I'll let you know once done. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7bd2a61:
|
I have made the changes. @gaearon Running Are we good here? |
I had to rebase it again because of some file name changes in this PR |
Thanks |
The removed lines in this PR were added by @gaearon in #11745. The reason was a tree-shaking bug in the rollup.
According to @lukastaegert, this bug has been fixed and added to rollup in v1.14.0
I was not sure whether to use the rollup version
1.14.0
or to upgrade it to the latest, so I updated it the latest (1.17.0
).Note: One odd observation was that I ran the test with version
0.52.1
and they all still seem to pass.