Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Function.prototype.apply in warningWithoutStack #14107

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Use Function.prototype.apply in warningWithoutStack #14107

merged 1 commit into from
Nov 5, 2018

Conversation

sophiebits
Copy link
Collaborator

@sophiebits sophiebits commented Nov 5, 2018 •
edited
Loading

console.error.apply() fails in IE9, but I verified this works (and it works everywhere else too). :)

Ref #13610.

@sophiebits
Use Function.prototype.apply in warningWithoutStack
a85c7d4 
console.error.apply() fails in IE9, but I verified this works (and it works everywhere else too). :)
gaearon
gaearon approved these changes Nov 5, 2018
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is much nicer, thanks

@sizebot
Copy link

sizebot commented Nov 5, 2018

Details of bundled changes.

Comparing: 8eca0ef...a85c7d4

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js -1.0% -0.5% 96.35 KB 95.39 KB 25.22 KB 25.09 KB UMD_DEV
react.development.js -1.6% -0.9% 60.48 KB 59.52 KB 16.26 KB 16.12 KB NODE_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.1% 704.43 KB 703.47 KB 163.21 KB 163.06 KB UMD_DEV
react-dom.development.js -0.1% -0.1% 699.74 KB 698.78 KB 161.83 KB 161.68 KB NODE_DEV
react-dom-test-utils.development.js -2.1% -1.2% 45.83 KB 44.87 KB 12.44 KB 12.29 KB UMD_DEV
react-dom-test-utils.development.js -2.1% -1.2% 45.55 KB 44.59 KB 12.38 KB 12.23 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js -1.6% -0.9% 61.56 KB 60.6 KB 16.05 KB 15.91 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js -1.6% -0.9% 61.24 KB 60.28 KB 15.92 KB 15.78 KB NODE_DEV
react-dom-server.browser.development.js -0.8% -0.4% 118.4 KB 117.44 KB 31.35 KB 31.21 KB UMD_DEV
react-dom-server.browser.development.js -0.8% -0.4% 114.53 KB 113.57 KB 30.39 KB 30.26 KB NODE_DEV
react-dom-server.node.development.js -0.8% -0.4% 116.45 KB 115.49 KB 30.93 KB 30.79 KB NODE_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.2% -0.1% 491.55 KB 490.59 KB 108.95 KB 108.8 KB UMD_DEV
react-art.development.js -0.2% -0.1% 423.34 KB 422.38 KB 91.92 KB 91.79 KB NODE_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.2% -0.1% 435.98 KB 435.02 KB 94.59 KB 94.46 KB UMD_DEV
react-test-renderer.development.js -0.2% -0.1% 431.2 KB 430.24 KB 93.44 KB 93.32 KB NODE_DEV
react-test-renderer-shallow.development.js -3.6% -1.9% 26.74 KB 25.78 KB 7.17 KB 7.03 KB UMD_DEV
react-test-renderer-shallow.development.js -4.5% -2.3% 21.13 KB 20.17 KB 5.73 KB 5.6 KB NODE_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.2% -0.1% 421.18 KB 420.22 KB 90.35 KB 90.22 KB NODE_DEV
react-reconciler-persistent.development.js -0.2% -0.1% 419.63 KB 418.67 KB 89.73 KB 89.6 KB NODE_DEV
react-reconciler-reflection.development.js -5.9% -2.7% 16.35 KB 15.39 KB 4.96 KB 4.83 KB NODE_DEV

create-subscription

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
create-subscription.development.js -10.3% -4.8% 9.29 KB 8.33 KB 3.03 KB 2.89 KB NODE_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.2% -0.1% 554.44 KB 553.47 KB 121.35 KB 121.2 KB RN_FB_DEV
ReactNativeRenderer-dev.js -0.2% -0.1% 554.11 KB 553.14 KB 121.25 KB 121.08 KB RN_OSS_DEV
ReactFabric-dev.js -0.2% -0.1% 544.63 KB 543.65 KB 118.86 KB 118.73 KB RN_FB_DEV
ReactFabric-dev.js -0.2% -0.1% 544.66 KB 543.69 KB 118.88 KB 118.74 KB RN_OSS_DEV

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

react-cache

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-cache.development.js -9.8% -4.2% 9.76 KB 8.8 KB 3.08 KB 2.95 KB NODE_DEV
react-cache.development.js -9.6% -4.0% 9.99 KB 9.03 KB 3.15 KB 3.02 KB UMD_DEV

Generated by 🚫 dangerJS

@sophiebits sophiebits merged commit da04058 into facebook:master Nov 5, 2018
nhunzaker
nhunzaker reviewed Nov 5, 2018
View reviewed changes
Copy link
Contributor

@nhunzaker nhunzaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree! Much nicer!

gaearon pushed a commit to gaearon/react that referenced this pull request Nov 6, 2018
@sophiebits @gaearon
Use Function.prototype.apply in warningWithoutStack (facebook#14107)
5360dbe 
console.error.apply() fails in IE9, but I verified this works (and it works everywhere else too). :)
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@sophiebits @jetoneza
Use Function.prototype.apply in warningWithoutStack (facebook#14107)
fe5804d 
console.error.apply() fails in IE9, but I verified this works (and it works everywhere else too). :)
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@sophiebits @n8schloss
Use Function.prototype.apply in warningWithoutStack (facebook#14107)
878b71c 
console.error.apply() fails in IE9, but I verified this works (and it works everywhere else too). :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhunzaker nhunzaker nhunzaker left review comments

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sophiebits @sizebot @nhunzaker @gaearon @facebook-github-bot