IE9: Unable to call apply on console.error when encountering an unknown tag #13610
Comments
|
What's the error? |
|
The spread operator turns into apply like so: // Before: console.error('Warning: ' + format, ...stringArgs);
console.error.apply(console, ['Warning' + format].concat(stringArgs))IE9 doesn't support
|
|
I can try to check this one as "good first issue" if you don't mind :) |
link-alex
added a commit
to link-alex/react
that referenced
this issue
Sep 11, 2018
Where console methods like log, error etc. don't have 'apply' method. Because of the lot of tests already expect that exactly console['method'] will be called - had to reapply references for console.error method facebook#13610
link-alex
added a commit
to link-alex/react
that referenced
this issue
Sep 12, 2018
Where console methods like log, error etc. don't have 'apply' method. Because of the lot of tests already expect that exactly console['method'] will be called - had to reapply references for console.error method facebook#13610
gaearon
pushed a commit
that referenced
this issue
Sep 12, 2018
* Fix warning without stack for ie9 Where console methods like log, error etc. don't have 'apply' method. Because of the lot of tests already expect that exactly console['method'] will be called - had to reapply references for console.error method #13610 * pass parameters explicitly to avoid using .apply which is not supported for console methods in ie9 * Minor tweaks
|
Should be fixed in 16.5.1 |
Simek
pushed a commit
to Simek/react
that referenced
this issue
Oct 25, 2018
* Fix warning without stack for ie9 Where console methods like log, error etc. don't have 'apply' method. Because of the lot of tests already expect that exactly console['method'] will be called - had to reapply references for console.error method facebook#13610 * pass parameters explicitly to avoid using .apply which is not supported for console methods in ie9 * Minor tweaks
jetoneza
pushed a commit
to jetoneza/react
that referenced
this issue
Jan 23, 2019
* Fix warning without stack for ie9 Where console methods like log, error etc. don't have 'apply' method. Because of the lot of tests already expect that exactly console['method'] will be called - had to reapply references for console.error method facebook#13610 * pass parameters explicitly to avoid using .apply which is not supported for console methods in ie9 * Minor tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was introduced in React 16.5.0.
If IE9 encounters an unknown html element in development, React crashes as it attempts to call console.error.apply here:
react/packages/shared/warningWithoutStack.js
Line 30 in b87aabd
This is reproduceable with the following CodePen:
Code
https://codepen.io/nhunzaker/pen/YOeZXv
Demo
https://s.codepen.io/nhunzaker/debug/YOeZXv/mWMoNxzPjbZk
The text was updated successfully, but these errors were encountered: