Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed *BaseTime Fiber attributes to *baseDuration #13156

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Renamed *BaseTime Fiber attributes to *baseDuration #13156

merged 1 commit into from
Jul 6, 2018

Commits on Jul 6, 2018

  1. Renamed selfBaseTime/treeBaseTime Fiber attributes to selfBaseDuratio… 

    …n/treeBaseDuration

This is an unobservable change to all but the (under development) DevTools Profiler plugin. It is being done so that the plugin can safely feature detect a version of React that supports it. The profiler API has existed since the 16.4.0 release, but it did not support the DevTools plugin prior to PR facebook#13058.

Side note: I am not a big fan of the term "base duration". Both it and "actual duration" are kind of awkward and vague. If anyone has suggestions for better names– this is the best time to bikeshed about them.
    Brian Vaughn committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    3c244db View commit details
    Browse the repository at this point in the history