Renamed *BaseTime Fiber attributes to *baseDuration #13156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n/treeBaseDuration This is an unobservable change to all but the (under development) DevTools Profiler plugin. It is being done so that the plugin can safely feature detect a version of React that supports it. The profiler API has existed since the 16.4.0 release, but it did not support the DevTools plugin prior to PR facebook#13058. Side note: I am not a big fan of the term "base duration". Both it and "actual duration" are kind of awkward and vague. If anyone has suggestions for better names– this is the best time to bikeshed about them.
bvaughn
requested review from
sophiebits,
sebmarkbage,
gaearon,
flarnie and
acdlite
gaearon
reviewed
Jul 6, 2018
| @@ -230,8 +230,8 @@ function FiberNode( | |||
| if (enableProfilerTimer) { | |||
| this.actualDuration = 0; | |||
| this.actualStartTime = 0; | |||
There was a problem hiding this comment.
Is this one (actualStartTime) intentionally still called "time"? Or would it be more consistent to rename it too?
If it's intentionally still "time", would you say "time" now always refers to timestamps and "duration" always means length? Or is it still different?
There was a problem hiding this comment.
Start time and commit time are accurate. They both contain performance.now() values. Actual and base durations contain time deltas.
There was a problem hiding this comment.
So yes, "time" now always means a point in time and "duration" always means a length of time.
There was a problem hiding this comment.
It's almost like this was the plan all along! 😁
gaearon
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #13148
This is an unobservable change to all but the (under development) DevTools Profiler plugin. It is being done so that the plugin can safely feature detect a version of React that supports it. The profiler API has existed since the 16.4.0 release, but it did not properly work with the DevTools plugin prior to PR #13058.
I chose to rename "time" to "duration" because it's more descriptive of what the field contains. That being said, the terms "actual duration" and "base duration" are pretty vague. If anyone has suggestions for better names– this is the best time to bikeshed about them.