[iOS] Use configuration type when adding ndebug flag to pods in release

[benhandanyan]

Summary:

While I was working on fixing the iOS debugger logic based on configuration name regex match, I wanted to know if other logic was also based on configuration names. I think I found and fixed the only other configuration name-based logic in the repo in this PR.

Changelog:

[IOS] [CHANGED] - Use configuration type when adding ndebug flag to pods in release

Test Plan:

In a fresh react-native project, I added to the Podfile:

    installer.aggregate_targets.each do |aggregate_target|
      aggregate_target.xcconfigs.each do |config_name, config_file|
          is_release = aggregate_target.user_build_configurations[config_name] == :release
          puts "aggregate_targets #{config_name} is_release: #{is_release}"
        end
    end

    installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
      target_installation_result.native_target.build_configurations.each do |config|
          is_release = config.type == :release
          puts "target_installation_results #{config.name} is_release: #{is_release}"
      end
    end

to confirm my logic. It output the following:

aggregate_targets Release is_release: true
aggregate_targets Local is_release: false
...
target_installation_results Local is_release: false
target_installation_results Release is_release: true
...

I also updated the applicable tests I could find for this logic.

[benhandanyan]

https://rubydoc.info/gems/cocoapods/Pod/Target#user_build_configurations-instance_method

[benhandanyan]

https://www.rubydoc.info/gems/xcodeproj/Xcodeproj/Project/Object/XCBuildConfiguration#type-instance_method

[cipolleschi]

This is great, amazing work. Thank you so much!

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in 462fae4.

[react-native-bot]

This pull request was successfully merged by @benhandanyan in 462fae4

^{When will my fix make it into a release? | How to file a pick request?}