[iOS] Enable hermes debugger by configuration type instead of configuration name

[benhandanyan]

Summary:

Fixes an issue where only iOS configurations with "Debug" in the name are configured to use the hermes debugger.

Changelog:

[IOS] [FIXED] - Enable hermes debugger by configuration type instead of configuration name

Test Plan:

Added new test scenarios that all pass:

ruby -Itest packages/react-native/scripts/cocoapods/__tests__/utils-test.rb
Loaded suite packages/react-native/scripts/cocoapods/__tests__/utils-test
Started
Finished in 0.336047 seconds.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
56 tests, 149 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
166.64 tests/s, 443.39 assertions/s

In a personal project with the following configurations:

project 'ReactNativeProject', {
    'Local' => :debug,
    'Development' => :release,
    'Staging' => :release,
    'Production' => :release,
  }

I added the following to my Podfile:

installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
        puts "#{config.name} is debug? #{config.type == :debug}"
    end
end

To confirm that my logic is correct:

Local is debug? true
Development is debug? false
Staging is debug? false
Production is debug? false

[facebook-github-bot]

Hi @benhandanyan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[cipolleschi]

This looks good to me, thanks for doing that and thanks for adding the tests!

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[benhandanyan]

@cipolleschi I just noticed that I didn't explictly return here and I wanted to flag it in case you think it should be added for consistency

[cipolleschi]

Its fine! i personally prefer to have an explicit return, but Ruby automatically returns the last line of a function, and many people thinks that that's idiomatic Ruby.

I prefer not to do that, because not many people know Ruby to that degree of confidence, so being explicit makes the code more readable for everyone.

[facebook-github-bot]

@cipolleschi merged this pull request in eda4f18.

[react-native-bot]

This pull request was successfully merged by @benhandanyan in eda4f18

^{When will my fix make it into a release? | How to file a pick request?}

[react-native-bot]

This pull request was successfully merged by @benhandanyan in 4ca9d72

^{When will my fix make it into a release? | How to file a pick request?}