Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Include autolinkin.h in OnLoad.cpp only if it exists (#47875)" #48156

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:

This reverts commit 5b2bbb8.

This is currently blocking reanimated as it's preventing the autolinked modules from being loaded. The fix is sadly not correct because the OnLoad.cpp file is available ONLY on New Architecture and the <autolinking.h> is always generated.

Changelog:

[INTERNAL] -

Test Plan:

N/A

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 6, 2024
@Dallas62
Copy link

Dallas62 commented Dec 7, 2024

Hello, I confirm it's blocking modules from being load on RN 0.76.4, could be great to release it fast since may lead to confusing issue. I detected it cause of RNCAsyncStorage Error and spend hours to cache clean, rebuild, ... After removing the throw on RNCAsyncStorage, found that other modules are not loaded. Despite the fact they are correctly generated via Codegen.
Maybe have a small CI test in addition to this fix (after), to prevent such blocking issue in a release ?
At least make sure a small project with Legacy Modules + TurboModule is able to start ?
Thanks for the reactivity of the investigation + revert PR !

@christocracy
Copy link

cause of RNCAsyncStorage Error and spend hours to cache clean, rebuild

Interesting. I don’t know much about TurboModules yet, but I did experience this phenomenon yesterday on a legacy project upgraded to 76.3.

eventually, I re-cloned my repo and it worked again.

@blakef
Copy link
Contributor

blakef commented Dec 9, 2024

Apologies, I've cherry-picked while working on conflicts from other picks. 94e2b5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants