Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.76] Revert "Include autolinkin.h in OnLoad.cpp only if it exists #667

Closed
cortinico opened this issue Dec 6, 2024 · 1 comment
Closed

[0.76] Revert "Include autolinkin.h in OnLoad.cpp only if it exists #667

cortinico opened this issue Dec 6, 2024 · 1 comment
Labels
Type Pick Request Pick requests to include commits inside a React Native release

Comments

@cortinico
Copy link
Collaborator

Target Branch(es)

0.76

Link to commit or PR to be picked

facebook/react-native#48156

Description

This is currently blocking reanimated as it's preventing the autolinked modules from being loaded. The fix is sadly not correct because the OnLoad.cpp file is available ONLY on New Architecture and the <autolinking.h> is always generated.
@cortinico cortinico added the Type Pick Request Pick requests to include commits inside a React Native release label Dec 6, 2024
@sunnylqm
Copy link

sunnylqm commented Dec 8, 2024

i think this is blocking all autolinked modules on android

@blakef blakef moved this from Inbox to Done / Picked in React Native 0.76 Releases Dec 9, 2024
@blakef blakef closed this as completed by moving to Done / Picked in React Native 0.76 Releases Dec 9, 2024
@vonovak vonovak mentioned this issue Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type Pick Request Pick requests to include commits inside a React Native release
Projects
React Native 0.76 Releases
Status: Done / Picked
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blakef @sunnylqm @cortinico