fix hermes param handling in test-e2e-local.js #48068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
vonovak
force-pushed
the
@vonovak/fix-testing-script
branch
from
4bbc216 to
f499de9
Compare
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @vonovak in 52f0927 When will my fix make it into a release? | How to file a pick request? |
vonovak
added a commit
that referenced
this pull request
Jan 15, 2025
Summary: why: running `yarn test-e2e-local -t "RNTestProject" -p "Android" -h false -c $GITHUB_TOKEN` would actually build the app with Hermes even though it's specified as disabled. This is because of the `if (argv.hermes == null)` condition whose body would not execute. The condition was changed [recently](f322dc7#diff-56f57bf0eac99b0fda1b2938aceb8d9b663db82c07cb405bd53a01c8689710ffR258). Reason for `await` being used: ``` Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ scripts/release-testing/test-e2e-local.js:303:32 Cannot get argv.hermes because property hermes is missing in Promise [1]. [prop-missing] scripts/release-testing/test-e2e-local.js 300│ 'reactNativeArchitectures=arm64-v8a', 301│ 'android/gradle.properties', 302│ ); 303│ const hermesEnabled = (argv).hermes === true; 304│ 305│ // Update gradle properties to set Hermes as false 306│ if (!hermesEnabled) { flow-typed/npm/yargs_v17.x.x.js [1] 80│ argv: Argv | Promise<Argv>; ``` ## Changelog: [INTERNAL] [FIXED] - fix `hermes` param handling in `test-e2e-local.js` Pull Request resolved: #48068 Test Plan: tested locally Reviewed By: cipolleschi Differential Revision: D66704263 Pulled By: robhogan fbshipit-source-id: f05f23b95e67bd20025e0b3448df0d284fcb62da
|
This pull request was successfully merged by @vonovak in 0d3f8c1 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
why: running
yarn test-e2e-local -t "RNTestProject" -p "Android" -h false -c $GITHUB_TOKENwould actually build the app with Hermes even though it's specified as disabled.This is because of the
if (argv.hermes == null)condition whose body would not execute.The condition was changed recently.
Reason for
awaitbeing used:Changelog:
[INTERNAL] [FIXED] - fix
hermesparam handling intest-e2e-local.jsTest Plan:
tested locally