Skip to content

Commit

Permalink
fix hermes param handling in test-e2e-local.js
Browse files Browse the repository at this point in the history
vonovak committed Dec 3, 2024

Unverified

This user has not yet uploaded their public signing key.
1 parent 318db8e commit f499de9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions scripts/release-testing/test-e2e-local.js
Original file line number Diff line number Diff line change
@@ -300,9 +300,10 @@ async function testRNTestProject(
'reactNativeArchitectures=arm64-v8a',
'android/gradle.properties',
);
const hermesEnabled = (await argv).hermes === true;

// Update gradle properties to set Hermes as false
if (argv.hermes == null) {
if (!hermesEnabled) {
sed(
'-i',
'hermesEnabled=true',
@@ -317,7 +318,7 @@ async function testRNTestProject(
exec('bundle install');
exec(
`HERMES_ENGINE_TARBALL_PATH=${hermesPath} USE_HERMES=${
argv.hermes === true ? 1 : 0
hermesEnabled ? 1 : 0
} bundle exec pod install --ansi`,
);

0 comments on commit f499de9

Please sign in to comment.