Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS): line break mode cpp changes and new functions #46130

Conversation

shubhamguptadream11
Copy link
Collaborator

@shubhamguptadream11 shubhamguptadream11 commented Aug 21, 2024

Summary:

Solves this issue: #44107

Changelog:

[IOS] [ADDED] - Line break mode for TextInput components. This includes cpp changes and new functions.

This PR is a breakdown of this PR.

Test Plan:

  • Tested builds in new and old architecture mode.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2024
@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against a4445ab

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 21, 2024
@shubhamguptadream11 shubhamguptadream11 changed the title feat(ios): line break mode cpp changes and new functions feat(iOS): line break mode cpp changes and new functions Aug 21, 2024
@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against a4445ab

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work with the refactoring, thanks for looking into this.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 23, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 6cab6c2.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @shubhamguptadream11 in 6cab6c2

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants