-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): line break mode property added for iOS #45968
fix(ios): line break mode property added for iOS #45968
Conversation
|
Base commit: fcd526d |
@cortinico @cipolleschi |
Why not |
@ecreeth This is iOS specific props. I followed convention from existing props: |
I know, the think is that there's other props without this IOS suffix that are platform specific like: |
I thought this makes much more sense by specifying platform in props. But I am okay to rename it. |
@cipolleschi @NickGerleman Can you guys please check this PR once? |
As I already mentioned, we're hyperfocused on New Architecture-only bug at the moment so we can't review PRs within a couple of days especially if they're not New Architecture bugfixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shubhamguptadream11, thanks for working on this.
This PR is too big, it will be quite hard to review and land it.
Can I suggest to split it in multiple parts?
Ideally, we can have:
- a part that introduce the C++ changes and new functions we need
- a part that updates the iOS part to consume those new functions, even though they are not usable from JS
- the last part which implement the Js APIs to use the new mode.
Hi @cipolleschi , Thanks for the feedback! I completely understand the concern. I'll split the PR into the suggested parts:
Thanks again for the guidance! |
Hi @cipolleschi I've gone ahead and split the original PR into three separate ones as suggested: [PR 1] - Introduces the C++ changes and new functions. |
Summary: Solves this issue: #44107 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [ADDED] - Line break mode for TextInput components. **This includes cpp changes and new functions.** This PR is a breakdown of [this](#45968) PR. Pull Request resolved: #46130 Test Plan: - Tested builds in new and old architecture mode. Reviewed By: andrewdacenko Differential Revision: D61656894 Pulled By: cipolleschi fbshipit-source-id: 9a25387cb27cded072e76575e6d2fca01963c621
…ons (#46129) Summary: Solves this issue: #44107 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [ADDED] - Line break mode for TextInput components. **This includes iOS updates to consume new cpp functions.** This PR is a breakdown of [this](#45968) PR. Pull Request resolved: #46129 Test Plan: - Tested builds in new and old architecture mode. Reviewed By: andrewdacenko Differential Revision: D61656969 Pulled By: cipolleschi fbshipit-source-id: 4c6ed983ad15841ce52443bba13962d45c04e756
Summary: Solves this issue: #44107 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [ADDED] - Line break mode for TextInput components. **This includes JS APIs for the new mode.** This PR is a breakdown of [this](#45968) PR. Pull Request resolved: #46128 Test Plan: - Added unit tests to cover the new JS APIs. - Verified that the new mode functions as expected through manual testing. Reviewed By: andrewdacenko Differential Revision: D61657004 Pulled By: cipolleschi fbshipit-source-id: 9fc5c40fc077bee8e1abc51b6eae2e0f0fcd9b8f
Summary:
Solves this issue: #44107
Changelog:
[IOS] [ADDED] - Line break mode for TextInput components
Test Plan:
'wordWrapping' | 'char' | 'clip' | 'head' | 'middle' | 'tail'
.