Fix rendering of textInput using lineHeight in android API level <28 #42673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53105649 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 25, 2024
…acebook#42673) Summary: Fix rendering of textInput using lineHeight in android API level <28 by removing call to ReactEditText.setLineHeight. ReactEditText.setLineHeight was introduced in API level 28 and we actually don't need to call this method changelog: [Internal] internal Differential Revision: D53105649
mdvacca
force-pushed
the
export-D53105649
branch
from
6078b14 to
0256172
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53105649 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 25, 2024
…acebook#42673) Summary: Fix rendering of textInput using lineHeight in android API level <28 by removing call to ReactEditText.setLineHeight. ReactEditText.setLineHeight was introduced in API level 28 and we actually don't need to call this method changelog: [Internal] internal Differential Revision: D53105649
mdvacca
force-pushed
the
export-D53105649
branch
from
0256172 to
69cbe5b
Compare
…acebook#42673) Summary: Fix rendering of textInput using lineHeight in android API level <28 by removing call to ReactEditText.setLineHeight. ReactEditText.setLineHeight was introduced in API level 28 and we actually don't need to call this method changelog: [Internal] internal Differential Revision: D53105649
|
This pull request was exported from Phabricator. Differential Revision: D53105649 |
mdvacca
force-pushed
the
export-D53105649
branch
from
69cbe5b to
ca712ef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53105649 |
Base commit: e04d1b4 |
|
This pull request has been merged in 142f13d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix rendering of textInput using lineHeight in android API level <28 by removing call to ReactEditText.setLineHeight.
ReactEditText.setLineHeight was introduced in API level 28 and we actually don't need to call this method (in any API level)
changelog: [Internal] internal
Differential Revision: D53105649