Skip to content

Commit

Permalink
Fix rendering of textInput using lineHeight in android API level <28 (#…
Browse files Browse the repository at this point in the history
…42673)

Summary:

Fix rendering of textInput using lineHeight in android API level <28 by removing call to ReactEditText.setLineHeight.
ReactEditText.setLineHeight was introduced in API level 28 and we actually don't need to call this method

changelog: [Internal] internal

Differential Revision: D53105649
  • Loading branch information
mdvacca authored and facebook-github-bot committed Jan 25, 2024
1 parent e04d1b4 commit 69cbe5b
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,9 @@ public boolean onKeyUp(int keyCode, KeyEvent event) {
@Override
public void setLineHeight(int lineHeight) {
mTextAttributes.setLineHeight(lineHeight);
super.setLineHeight(lineHeight);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
super.setLineHeight(lineHeight);
}
}

@Override
Expand Down

0 comments on commit 69cbe5b

Please sign in to comment.