Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): set top of perf monitor to statusbar height #38262

Closed
wants to merge 2 commits into from

Conversation

zerosrat
Copy link
Contributor

@zerosrat zerosrat commented Jul 9, 2023

Update RCTPerfMonitor.mm

Summary:

Change the top offset of perf monitor component. As it is overlapped by dynamic island of iPhone 14 Pro series.

Before:
image

After:
image

Changelog:

[iOS] [Fixed] - Change the top of perf monitor component.

Test Plan:

noop

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2023
@analysis-bot
Copy link

analysis-bot commented Jul 9, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,001,914 +452
android hermes armeabi-v7a 8,255,976 +601
android hermes x86 9,511,053 +547
android hermes x86_64 9,356,938 +569
android jsc arm64-v8a 9,614,948 +419
android jsc armeabi-v7a 8,741,584 +557
android jsc x86 9,701,900 +516
android jsc x86_64 9,948,457 +514

Base commit: 0519c11
Branch: main

@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zerosrat zerosrat requested a review from NickGerleman July 11, 2023 01:33
@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 11, 2023
@facebook-github-bot
Copy link
Contributor

@NickGerleman merged this pull request in 5ba8de0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants