[iOS] reduce cursor size for multiline(TextInput) #36583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…InputShadowView Summary: The `NSMutableAttributedString` was initialized with the same backing store as the cached attributed string on the shadow queue (background thread), but then passed to the main thread and ultimately the JS thread. This explicitly copies the mutable attributed string into an immutable one on the shadow thread before passed off to other threads, which hopefully will address the `convertIdToFollyDynamic` crash that always includes `RCTBaseTextInputShadowView` touching an attributed string on the shadow queue in the trace. Changelog: [iOS][Fixed] - Possible fix for convertIdToFollyDynamic crash in RCTBaseTextInputView and RCTEventDispatcher Reviewed By: sammy-SC Differential Revision: D38133150 fbshipit-source-id: f371da5d17a32c3341287cd3e9730b31a98495f9
Summary: Bumping main to latest version of CLI available; in particular, we want to ensure to propagate this fix react-native-community/cli#1655. After merging, we'll cherry-pick in the `0.70-stable` branch. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Changed] - bump CLI to v9.0.0-alpha.5 Pull Request resolved: facebook#34275 Test Plan: CI Reviewed By: NickGerleman Differential Revision: D38151383 Pulled By: dmitryrykun fbshipit-source-id: afdafb496a159ad766dd322a4aab4bda6146edf0
Summary: This change is in preparation of adding a separate `VirtualizedList_EXPERIMENTAL` component. Both the original, and experimental lists use `VirtualizedListContext`, which itself references back to the VirtualizedList class type. VirtualizedList private methods are currently included in the type system, and are called in other VirtualizedList code (see facebook@b2f871a). This prevents Flow from seeing the two classes are compatible if "private" methods change. My first attempt was to parameterize the context, to allow both `VirtualizedList`, and `VirtualizedList_EXPERIMENTAL` to use the same code without sacrificing type safety or adding further duplication. This added more complexity than it is worth, so I am instead loosening the type on VirtualizedListContext to pass around a more generic handle. Changelog: [Internal][Changed] - Allow VirtualizedListContext to support different component type Reviewed By: javache Differential Revision: D38017086 fbshipit-source-id: 91e8f6ab2591d3ae9b7f9263711b4a39b78f68e0
Summary: # This Change react-native-community/discussions-and-proposals#335 discussed a set of problems with VirtualizedList and focus. These were seen as severe externally for a11y on desktop. The issues center on users of keyboard and accessibility tools, where users expect to be able to move focus in an uninterrupted loop. The design and implementation evolved to be a bit more general, and without any API-surface behavior changes. It was implemented and rolled out externally as a series of changes. The remaining changes that were not upstreamed into RN are rolled into facebook#32646 This diff brings this change into the repo, as a separate copy of VirtualizedList, to measure its impact to guardrail metrics, without yet making it the default implementation. The intention is for this to be temporary, until there is confidence the implementation is correct. ## List Implementation (more on GitHub) This change makes it possible to synchronously move native focus to arbitrary items in a VirtualizedList. This is implemented by switching component state to a sparse bitset. This was previously implemented and upstreamed as `CellRenderMask`. A usage of this is added, to keep the last focused item rendered. This allows the focus loop to remain unbroken, when scrolling away, or tab loops which leave/re-enter the list. VirtualizedList tracks the last focused cell through the capture phase of `onFocus`. It will keep the cell, and a viewport above and below the last focused cell rendered, to allow movement to it without blanking (without using too much memory). ## Experimentation Implementation A mechanism is added to gate the change via VirtualizedListInjection, mirroring the approach taken for Switch with D27381306 (facebook@683b825). It allows VirtualizedList to delegate to a global override. It has a slight penalty to needing to import both modules, but means code which imports VirtualizedList directly is affected the changes. Changelog: [Internal][Added] - Add VirtualizedList_EXPERIMENTAL (CellRenderMask Usage) Reviewed By: lunaleaps Differential Revision: D38020408 fbshipit-source-id: ad0aaa6791f3f4455e3068502a2841f3ffb40b41
…nking mocks (facebook#34260) Summary: The removeEventListener method has been removed from AccessibilityInfo and Linking in this PR: facebook#33580, so I believe we can remove it from the mocks. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Removed] - Remove removeEventListener from AccessibilityInfo and Linking mocks Pull Request resolved: facebook#34260 Test Plan: I executed jest and everything is still green. Reviewed By: dmitryrykun Differential Revision: D38198653 Pulled By: GijsWeterings fbshipit-source-id: 72d10ca54cd505d7c76e7531c9df718b1a9b9ed1
Summary: At the moment we are having a bug that whenever we hit a "Done" button in an input field, a value is not submitted back, so the users cannot complete their work. Here is an example: https://pxl.cl/28xFq To fix it, we call a textInputShouldSubmitOnReturn method on Accessory button click. Changelog [IOS][Fixed] - Fix keyboard accessory button not triggering onSubmitEditing Reviewed By: dmitryrykun Differential Revision: D38152974 fbshipit-source-id: fc026dffd641966cd3d342d95a56c43c71008036
…tener (facebook#34281) Summary: I've noticed that `BackHandler.removeEventListener()` performs two same `indexOf()` calls on an array that is not changing. By removing extra `indexOf` we can slightly improve time complexity of `BackHandler.removeEventListener()` from O(2n) to O(n) ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Fixed] - Remove extra indexOf call in BackHandler.removeEventListener Pull Request resolved: facebook#34281 Test Plan: 1. Add the following code to any function component ```javascript BackHandler.addEventListener('hardwareBackPress', () => true).remove(); ``` 2. Press on hardware back button Expected result: Application closes Reviewed By: dmitryrykun Differential Revision: D38198510 Pulled By: javache fbshipit-source-id: eab6a57689a536623138a4b3ebddbf9ba87d281f
…ebook#34222) Summary: When in `use_frameworks!` + `hermes_enabled` mode, the React podspecs have not dependency to the `React-hermes` podspec. the `HermesExecutorFactory.h` is not available [here](https://github.com/facebook/react-native/blob/1d997ce6d67242b9f667b01365c5e719c3d3f8d7/React/AppSetup/RCTAppSetupUtils.h#L15) and [here](https://github.com/facebook/react-native/blob/1d997ce6d67242b9f667b01365c5e719c3d3f8d7/React/CxxBridge/RCTCxxBridge.mm#L44). The app will fallback to JSCRuntime and crash in release build because the JSCRuntime cannot evaluate Hermes bundles. The pr tries to add `React-hermes` to Framework Search Paths and make the `HermesExecutorFactory.h` reachable when in use_frameworks mode. This pr should fix the problem mentioned in [0.70 release discussion](reactwg/react-native-releases#26 (reply in thread)). ## Changelog [iOS] [Fixed] - Fix Hermes executor not available when `use_frameworks` is enabled Pull Request resolved: facebook#34222 Test Plan: use patch-package to apply the change to a RN 0.69.1 project with the following test cases: - old architecture + jsc - new architecture + hermes - old architecture + `use_frameworks! :linkage => :static` + hermes - old architecture +`use_frameworks! :linkage => :static` + hermes + release build Reviewed By: sammy-SC Differential Revision: D38112717 Pulled By: cipolleschi fbshipit-source-id: ee78527f4686400856ab9a055cf30b20900afc17
…4267) Summary: Adding grid role to ViewAccessibility to fix flow errors. fixes facebook#30861 fixes facebook#30972 ## Changelog [General] [Fixed] - Adding grid role to ViewAccessibility to fix flow errors. Pull Request resolved: facebook#34267 Test Plan: <details><summary>flow error for missing accessibilityRole type grid</summary> <p> <image src="https://user-images.githubusercontent.com/24992535/180728969-beccb7f7-d882-4a94-831d-1c08822fc030.png" width="800" /> </p> </details> <details><summary>adding grid role to ScrollView</summary> <p> https://user-images.githubusercontent.com/24992535/180721100-62de76af-ea23-44a6-816e-f6fa39835b77.mp4 </p> </details> <details><summary>adding grid role to FlatList</summary> <p> https://user-images.githubusercontent.com/24992535/180724852-861c2981-0b06-4c66-a983-0017785062fe.mp4 </p> </details> <details><summary>adding grid role to SectionList</summary> <p> https://user-images.githubusercontent.com/24992535/180788810-d1869381-1e6b-42aa-b9b2-a84aece41326.mp4 </p> </details> Reviewed By: NickGerleman Differential Revision: D38121921 Pulled By: dmitryrykun fbshipit-source-id: 3bc335b3a525e75ae2e032f6a35540b3e95cd6a8
Summary: cherry-pick changes from facebook#34214 to main. because the `react_native_pods.rb` on main is quite different from 0.69, i have separated pr for the change. ## Changelog [iOS] [Fixed] - Fix React-bridging headers import not found Pull Request resolved: facebook#34271 Test Plan: RNTester + pod install and verify pod targets to have `React-bridging` in header search paths. Reviewed By: cipolleschi Differential Revision: D38122074 Pulled By: dmitryrykun fbshipit-source-id: 64569abbfa3a684f0d6b84c9e3222bfc9a171061
Summary: [Changelog][General] - Bump packages version number: react-native/eslint-plugin-specs: ^0.71.0, react-native-gradle-plugin: ^0.71.0, react-native-codegen: ^0.71.0 Reviewed By: cortinico Differential Revision: D38204441 fbshipit-source-id: 7188aae2decb307852e55a1b6b1180f3f068a75c
…es the same output (facebook#34251) Summary: Flow and TypeScript are two very similar programming languages. They are both recognizable as inputs for turbo module codegen. It is reasonable to require equivalent Flow and TypeScript turbo module definition generates the same output. I add some test cases to ensure this. Glad that no functional inconsistency is found here. ## Changelog [General] [Changed] - codegen: ensure equivalent Flow and TypeScript TM definition generates the same output Pull Request resolved: facebook#34251 Test Plan: `yarn jest` passed in `packages/react-native-codegen` Reviewed By: dmitryrykun Differential Revision: D38116756 Pulled By: cipolleschi fbshipit-source-id: 476adbd171a35813923f2020c826d21b1fc2eeed
Summary: Implements most of systrace using androidx.tracing, this makes it usable using Android Studio profiler systrace. ## Changelog [Android] [Added] - Improve OSS systrace Pull Request resolved: facebook#34252 Test Plan: Run a systrace in Android Studio for RN Tester and make sure RN specific sections are there. <img width="1263" alt="image" src="https://user-images.githubusercontent.com/2677334/180593493-fc087b4a-2253-43e1-b246-bed3e7bba7ac.png"> Reviewed By: NickGerleman Differential Revision: D38116890 Pulled By: dmitryrykun fbshipit-source-id: 744bedbf9ad4004488340a5b4e93d936d9a1e582
Summary: VirtualizedList_EXPERIMENTAL has a different flow signature from VirtualizedList. This does not cause an error in unit tests, which are untyped, but prevents injecting VirtualizedList_EXPERIMENTAL via the current API from flowtype. This diff updates the injection interface to allow a more relaxed type, validating safety at runtime. Changelog: [Internal][Changed] - Allow injecting looser VirtualizedList Reviewed By: javache Differential Revision: D38143682 fbshipit-source-id: 054bbc5092823f4e4413d69d3d72a7ecdd71a6a2
Summary: If FlatList is passed non-array data it will return `undefined` as the result of `getItemCount()` to VirtualizedList. This change makes it return `0` instead, to signify there are no valid items to attempt to accces. There are a set of invariants on properties passed to FlatList, to curb incorrect types at runtime, but there is existing code which runs into the condition. Changelog: [Internal][Fixed] - Guard FlatList getItemCount() against non-array data Reviewed By: javache Differential Revision: D38198351 fbshipit-source-id: 9efd0df7eeeba17078e2c838d470c4b0d621b9a0
…RIMENTAL Summary: Existing code may pass negative values for `initialScrollIndex`, which the previous implemnentation handled gracefully. Handle the case gracefully in VirtualizedList_EXPERIMENTAL as well. Changelog: [Internal][Fixed] - Gracefully handle negative initialScrollIndex in VirtualizedList_EXPERIMENTAL Reviewed By: rshest Differential Revision: D38183625 fbshipit-source-id: 9aea91c4cf3ce2190d769f34ce728a109efc88d4
…34294) Summary: The current `test-manual-e2e.sh` script is broken on Android + Hermes + New App Template. This commit fixes it. Specifically: - There is no need to generate Maven Artifacts for RN Tester, as RN Tester consumes them from source. - There is instead a need to generate Maven Artifacts for New App Template, as they need to be included inside the NPM package. - The `:ReactAndroid:hermes-engine:installArchives` task needs to invoked to also generate the Hermes-engine .aar for bundling. ## Changelog [Internal] - Fix test-manual-e2e on Android/Hermes for New App Template Pull Request resolved: facebook#34294 Test Plan: I've tested this against the `0.70-stable` branch and I was able to run an App from the New Template properly. Reviewed By: dmitryrykun Differential Revision: D38239238 Pulled By: cortinico fbshipit-source-id: b3d95bad21515b12a91e29147e70ba8323896660
…acebook#34254) Summary: Fixes facebook#34120 The new React Native architecture doesn't check `needsCustomLayoutForChildren` so it wrongly positions native views on Android. In facebook#34120 there are videos comparing the positioning of a native action view in the old and the new architecture. This PR passes the parent tag to the `updateLayout` method of the `SurfaceMountingManager`. The `SurfaceMountingManager` calls `needsCustomLayoutForChildren` on the parent view manager (copied the code from the `NativeViewHierarchyManager` in the old architecture). **NOTE** - I wasn't sure where to get the parent shadow view from so I've put in my best guesses where I could and left it as `{}` otherwise. ## Changelog [Android] [Fixed] - Migrate `needsCustomLayoutForChildren` check to the new architecture Pull Request resolved: facebook#34254 Test Plan: I checked the fix in the repro from facebook#34165. Here is a video of the action view closing using the native button that is now visible in the new architecture. https://user-images.githubusercontent.com/1761227/180607896-35bf477f-4552-4b8a-8e09-9e8c49122c0c.mov Reviewed By: cipolleschi Differential Revision: D38153924 Pulled By: javache fbshipit-source-id: e2c77fa70d725a33ce73fe4a615f6d884312580c
Summary: Implement the `GlobalLexicalScopeNames` request and response: > Returns all let, const and class variables from global scope. The returned elements are filtered to remove internal entries that are prefixed with `?`: https://www.internalfb.com/code/fbsource/[4398b6a77500984e8536c06d58c691cd7c591477][history]/xplat/hermes/lib/IRGen/ESTreeIRGen-func.cpp?lines=49&base=da0d9de8a0d2 Changelog: [Internal] Reviewed By: jpporto Differential Revision: D38119568 fbshipit-source-id: 5c74dc7fa58d8dbc784bf39ac5baf85788a3df7a
Summary: VirtualizedList state is represented in terms of [first, last] ranges, where it is possible to express a zero-cell range by having [n, n-1]. This includes some awkward examples, like [0, -1] being valid. CellRenderMask assumes `addCells` is called with at least one cell, with VirtualizedList previously guarding against adding the no cell case. This guard is present for adding main cell regions, but not for `_initialRenderRegion()`, which can be overridden to have a zero length as well. This moves the `CellRenderMask` to be permissive of zero-length cell regions, and removes the caller guard. Changelog: [Internal][Fixed] - Allow empty cell ranges in CellRenderMask Reviewed By: rshest Differential Revision: D38184444 fbshipit-source-id: d2dadfdd9628b24f894126d63b1eb93f6387b877
…Plugin (facebook#34296) Summary: I've realized that the gradle plugin is currently looking at `.js` files for task re-execution. This means that, while the *.ts would still be considered when the codegen is invoked, an edit on one of those file, won't retrigger the codegen on Android. This change fixes it so that we consider both `*.ts` and `*.js` files. ## Changelog [Android] [Fixed] - Make sure *.ts files are considered for task avoidance in the Gradle Plugin Pull Request resolved: facebook#34296 Test Plan: Tests are attached. Reviewed By: cipolleschi Differential Revision: D38246125 Pulled By: cortinico fbshipit-source-id: 80efcc9ef747c598ca040d65b25d270593c8aed2
Summary: Changelog: [Internal] Reviewed By: evanyeung Differential Revision: D38264284 fbshipit-source-id: 8e2d6f99914b282ab1ef8ede60e5ac236747faf4
Summary: Changelog: [General][Changed] - `eslint-plugin-specs` package has prepack hook that changes `PACKAGE_USAGE` variable of `react-native-modules.js` to `true`. This changed file is can then be published to NPM, but should not be committed to the repo. This diff adds postpack hook that reverts the change, so we do not have to do it manually. Reviewed By: cipolleschi Differential Revision: D38244367 fbshipit-source-id: 818dbdea82e7e4b89094b3e27ae2d63b9e736659
…acebook#34287) Summary: While I was working on rewriting `react-native-slider` to Fabric I found a weird bug that prevented the slider to be set as disabled (to be exact: call the method `slider.setEnabled(false)`. As it turned out the `accessibilityState` (with value: `accessibilityState={{disabled: true}}` prop occurred after the `enabled={false}` prop that I was passing to the slider, which lead to both of this props overwrite each other. Handling of `accessibilityState` props inside view leads to always overwriting the enabled prop to true (even if we explicitly set it to `{disabled: false}`. Workaround for this was to reorder the props, so that the `accesibilityState` occur before `disabled`, but I think it's better to not set `view.setEnabled(true)` if we are passing a disabled property. ## Changelog [Android] [Fixed] - Fix accessibilityState overwriting view's disabled state on Android Pull Request resolved: facebook#34287 Test Plan: Change order of props inside native component implementation (that `disabled` occurs before `accesibilityState`). For example: `Libraries/Components/Slider/Slider.js` <details> <summary>Video showing the bug in RNTester (using Switch component)</summary> https://user-images.githubusercontent.com/52801365/181287547-964f50e2-55dc-450f-b413-0d1c14d4bb83.mp4 </details> Reviewed By: NickGerleman Differential Revision: D38209232 Pulled By: dmitryrykun fbshipit-source-id: 93d423716f89b45251be9d5aefcf01f7bd776f2c
Summary: Metro release notes: https://github.com/facebook/metro/releases/tag/v0.72.0 Changelog: [Internal] Reviewed By: robhogan Differential Revision: D38245699 fbshipit-source-id: d14cfda8c694f11ffacfb959cf81aa8906923648
…book#34298) Summary: The `codegenConfig` unified configuration for New Architecture on Android relies on the Gradle plugin finding the package.json correctly. Currently we use the `root` folder to resolve the package.json. This works fine when invoking the codegen for the app module, but it doesn't work well when invoking the codegen for modules. This extends the algo to make sure we first, look for a `package.json` in `..` and fallback to the one in the root if not found. ## Changelog [Internal] - Improve package.json search mechanism for codegenConfig support Pull Request resolved: facebook#34298 Test Plan: It's hard to write a unit test for this as it's inside a lambda, I'll look into doing this though. I've tested this on RNNewArchitectureApp and it works fine. Reviewed By: cipolleschi Differential Revision: D38249663 Pulled By: cortinico fbshipit-source-id: 3cfd6a31e9f75d7b19b15f77bbd5131af42be9d3
Summary: This change adds the following methods to jsi::BigInt * [static] fromInt64(value): creates a jsi::BigInt from a signed 64-bit value * [static] fromUint64(value): creates a jsi::BigInt from an unsigned 64-bit value * [static] strictEquals(a, b): return a === b, a and b are BigInts * asInt64(): truncates the BigInt to a single signed 64-bit integer; throws a JSIException if the truncation is lossy. * getInt64(): truncates the BigInt to a single signed 64-bit integer * isInt64(): returns true if the BigInt can be truncated losslessly to an int64_t * asUint64(): truncates the BigInt to a single unsigned 64-bit integer; throws a JSIException if the truncation is lossy. * getUint64(): truncates the BigInt to a single unsigned 64-bit integer * isUint64(): returns true if the BigInt can be truncated losslessly to an uint64_t * toString(radix): converts the BigInt to a string representing the number in the given radix. A lossy truncation is one that yields a result from which the BigInt cannot be reconstructed from, i.e., * BigInt::fromInt64(b.toInt64()) !== b * BigInt::fromUint64(b.toUint64()) !== b Changelog: [Internal] Reviewed By: kodafb Differential Revision: D37909139 fbshipit-source-id: 172848024f8367aed73cc602f38cde22f03cac8f
Summary: Calculation of TransformedFrames was a method introduced by D37994809 (facebook@64528e5) to fix rendering of inverted flat lists. We found that this operation is crashing in fb4a causing the UBN T127619309 This diff creates a feature flag to disable the calculation of TransformedFrames in Layoutable ShadowNodes. **The goal of this diff is to revert the behavior introduced by D37994809 (facebook@64528e5faa445907b8287b412c344f30c20fca61)** The featureFlag is disabled in fb4a and enabled in react AR (because ReactAr apps relies on the calculation of TransformedFrames and these apps are not affected) The root cause of the bug will be fixed by D38280674 (which still requires more testing and investigation) changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D38286857 fbshipit-source-id: 721cd0554ae6a6b369b3f8dbb584160a270d0f18
Summary: Pull Request resolved: facebook#34307 There are unreleased changes on eslint-config-react-native-community, I'm bumping the version for this package so we can publish it. Changelog: [General] [Changed] - Bump eslint-config-react-native-community Reviewed By: dmitryrykun Differential Revision: D38279512 fbshipit-source-id: 46492f7e99d31c0a5917d41726ecc20fada1582f
Summary: ### Follow-up - facebook#34103 - facebook#33823 #### Debug/Release further tested on RN 0.70.0-rc.0-1 - leotm/react-native-template-new-architecture#775 - builds/runtime: locally on `macos-13` b2 - builds: in CI `ubuntu-20.04` latest (not yet beta `ubuntu-22.04`) cc cortinico dulmandakh ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Changed] - Bump Gradle to 7.5.0 Pull Request resolved: facebook#34310 Test Plan: Everything builds and runs as expected. Reviewed By: cipolleschi Differential Revision: D38311861 Pulled By: cortinico fbshipit-source-id: c4e9e7a9052a067ffabae87204d20190ef46b351
Summary: I'm applying the same fix I applied to the Template. This allows us to load Flipper without using reflection on RN Tester. Changelog: [Internal] [Changed] - Do not use reflection to load Flipper on RN Tester Reviewed By: cipolleschi Differential Revision: D38745404 fbshipit-source-id: c17fbd74df31441467e448f21c35171a7f2532ff
Summary: Changelog: [RNTester][Internal] nohover pointerevent attributes platform test fixes In implementing full support of nohover pointerevents I discovered a couple issues with my initial port of the web platform test — specifically I forgot to update the calls to `checkPointerEventAttributes` to be "touch" instead of "mouse" and I had forgotten to remove the `pointerMove` event from the expected pointer event order. Reviewed By: lunaleaps Differential Revision: D38718994 fbshipit-source-id: d189a4b5cf3042c9f493ac876062f4f60219ae2b
Summary: Changelog: [General][Changed] - Copied and refactored the current devtools highlighting code from Inspector into its own module and add to the top level `AppContainer`. The effect is that the highlight stills shows without Inspector opened. This diff copies the current devtools highlighting logic from Inspector into a module and add to the top level `AppContainer`. The effect is without Inspector opened, the highlight will still show. ## Context This is the first diff for "Component Tab Automatically Highlight Elements". The idea is to replicate the behavior on Web to RN. ## Behavior on Web: - highlight shows whenever an element in the component list is hovered - Selecting an element doesn't keeps the highlight showing. on RN (before this diff): - when RN inspector opens: selecting an element keeps the highlight showing - when RN inspector closes: stop showing highlihgintg. on RN(this diff) - selecting an element keeps the highlight showing ## TODO - See if highlighting event can be sent on hover, instead of when an element is selected. Reviewed By: lunaruan Differential Revision: D38568135 fbshipit-source-id: d168874677d08a9c5526a7f896943579da804565
Summary: Support MapBuffer in TextInput State. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D38546271 fbshipit-source-id: 93e7fd79d9d8473dd646410f3047fcfafa8516f1
Summary: Unfortunately my last diff didn't completely fix this; now there are more printed parameters than arguments provided to the formatter. Easy fix, confirmed this works by running internally. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D38678116 fbshipit-source-id: 51f32905debc1946bc260f06a5bdc2f43141ddf4
Summary:
Currently the PropSetter parser parses all border{TopLeft,TopRight,...}Radius props except for `borderRadius`.
This is the fix.
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D38678226
fbshipit-source-id: 8c5d67a652c2b327aa50a997e8e886630fe139c0
Summary: This sync includes the following changes: - **[229c86af0](facebook/react@229c86af0 )**: Revert "Land enableClientRenderFallbackOnTextMismatch" ([facebook#24738](facebook/react#24738)) //<Andrew Clark>// - **[c3d7a7e3d](facebook/react@c3d7a7e3d )**: Bugfix: Offscreen instance is null during setState ([facebook#24734](facebook/react#24734)) //<Andrew Clark>// - **[fcd720d36](facebook/react@fcd720d36 )**: [Transition Tracing] Push Transition When Offscreen Becomes Visible ([facebook#24718](facebook/react#24718)) //<Luna Ruan>// - **[5cc2487e0](facebook/react@5cc2487e0 )**: bump versions for next release ([facebook#24725](facebook/react#24725)) //<Josh Story>// - **[54f17e490](facebook/react@54f17e490 )**: [Transition Tracing] Fix Cache and Transitions Pop Order ([facebook#24719](facebook/react#24719)) //<Luna Ruan>// - **[7cf8dfd94](facebook/react@7cf8dfd94 )**: [Transition Tracing] Create/Process Marker Complete Callback ([facebook#24700](facebook/react#24700)) //<Luna Ruan>// - **[327e4a1f9](facebook/react@327e4a1f9 )**: [Follow-up] Land enableClientRenderFallbackOnTextMismatch //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions a8c9cb1...229c86a jest_e2e[run_all_tests] Reviewed By: rickhanlonii Differential Revision: D38738652 fbshipit-source-id: 35b6b3cbfdbdafc28a356b53af6456aaa1949432
Summary: CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: facebook#34354 _macOS 13b, RN 0.70.0-rc.3_ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Added] - Update template to gitignore `android/app/.cxx` Pull Request resolved: facebook#34430 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D38752097 Pulled By: cortinico fbshipit-source-id: 61c31317d5e45f831445841f3e14da871b3903e5
…riant values (facebook#34003) Summary: Add new fontVariant values: stylistic-one(ss01) -> stylistic-twenty(ss20) stylistic-three(ss01) stylistic-two(ss02) stylistic-three(ss03) stylistic-four(ss04) stylistic-five(ss05) stylistic-six(ss06) stylistic-seven(ss07) stylistic-eight(ss08) stylistic-nine(ss09) stylistic-ten(ss10) stylistic-eleven(ss11) stylistic-twelve(ss12) stylistic-thirteen(ss13) stylistic-fourteen(ss14) stylistic-fifteen(ss15) stylistic-sixteen(ss16) stylistic-seventeen(ss17) stylistic-eighteen(ss18) stylistic-nineteen(ss19) stylistic-twenty(ss20) References: https://developer.apple.com/fonts/TrueType-Reference-Manual/RM09/AppendixF.html#Type3 https://docs.microsoft.com/en-us/typography/opentype/spec/featurelist Example: `<Text style={{ fontVariant: ['stylistic-three', 'stylistic-five'] }}> Hello World! </Text>` ## Changelog [iOS] [Added] - Add new fontVariant values: stylistic-one(ss01) -> stylistic-twenty(ss20) [Android] [Added] - Add new fontVariant values: stylistic-one(ss01) -> stylistic-twenty(ss20) Pull Request resolved: facebook#34003 Test Plan:  Reviewed By: cipolleschi Differential Revision: D37118078 Pulled By: cortinico fbshipit-source-id: 6a8366638f8181b5db6b2c12c48a5ad65e1e598f
Summary: changelog: [internal] This is shipped, let's remove gating Reviewed By: philIip Differential Revision: D38745414 fbshipit-source-id: 21381a89b01040f2209aeb458cef2637d21e981d
…#34435) Summary: Pull Request resolved: facebook#34435 Currently we expose native code (.h, .cpp) inside the src/main/java folder. This is making impossible for users on New Architecture to open the project inside Android Studio. The problem is that the src/main/java is reserved to Java/Kotlin sources only. AGP 7.2 also removed support for mixed source roots: https://developer.android.com/studio/releases/gradle-plugin#duplicate-content-roots This is essentially forcing users to write Java code without any autocompletion as all the React Native Java classes are considered C++ files. I'm addressing this issue folder by folder by moving them from ReactAndroid/src/main/java/com/facebook/... to ReactAndroid/src/main/jni/react/... This is the diff for fabricjni Changelog: [Internal] [Changed] - Do not store .cpp/.h files inside src/main/java - fabricjni Reviewed By: cipolleschi Differential Revision: D38741130 fbshipit-source-id: f9e3e4514d3ae0ddeac65256928d71d5134d08f8
…ok#34436) Summary: This is an attempt to fix the broken `test_buck` as the `/textinput` target now needs to access the Kotlin stdlib dependencies ## Changelog [Internal] - Fix test_buck by providing exported deps for textinput target Pull Request resolved: facebook#34436 Test Plan: Will wait for a CircleCI result Reviewed By: cipolleschi Differential Revision: D38782473 Pulled By: cortinico fbshipit-source-id: 72265c34092372189d75df732b64a1e370453472
Summary: Changelog: [Internal] Include FlexLayout C++ source to ReactCommons Reviewed By: d16r, NickGerleman Differential Revision: D38716145 fbshipit-source-id: 0ca2ab040e72168f2f1b479609b6cda2787eba66
Summary: Pull Request resolved: facebook#34404 Mirrors D38457812 (facebook@063c2b4) and D38632454 (facebook@06b55a3), this enables pedantic warnings for iOS in OSS, so that the warning level matches the internal. This is enabled through the `GCC_WARN_PEDANTIC` xcconfig flag (part of "Apple Clang - Warning Policies"), which controls whether "-pedantic" is passed to clang. Changelog: [iOS][Changed] - Enable pedantic warnings in C++ podspecs Reviewed By: cipolleschi Differential Revision: D38681644 fbshipit-source-id: 724160fbe03660fcfd12ea0ffeedaab448c66a5f
# Conflicts: # .circleci/config.yml # .flowconfig # .flowconfig.android # CHANGELOG.md # Libraries/AppDelegate/RCTAppDelegate.h # React/Fabric/RCTSurfaceTouchHandler.mm # ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactNativeHost.kt # ReactAndroid/src/main/jni/CMakeLists.txt # ReactCommon/hermes/inspector/chrome/MessageTypes.cpp # ReactCommon/hermes/inspector/chrome/MessageTypes.h # ReactCommon/hermes/inspector/tools/message_types.txt # package.json # packages/rn-tester/android/app/build.gradle # packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.java # repo-config/package.json # scripts/react_native_pods.rb # template/_flowconfig # template/android/app/build.gradle # template/android/app/src/main/java/com/helloworld/MainApplication.java # template/android/app/src/main/jni/CMakeLists.txt # template/ios/HelloWorld/AppDelegate.mm # template/package.json # yarn.lock
…ructions Add deploy instructions back to README
…tream Update Expensify/react-native fork from upstream
This is a temporary addition to help circumvent a bug on android. Long term we want to fix the root cause of the problem. - RN issue: facebook#35350 - Expensify issue: Expensify/App#11321 (comment)
…llvar-position feat: add `verticalScrollbarPosition` prop to `ScrollView`
facebook-github-bot
added
the
CLA Signed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently in multiline input the cursor touches the previous line.
So this reduces its height sets its position so that I does not touch previous line.
This PR will also fix the issue #28012 (Problem with TextInput lineHeight on iOS)
Changelog
[IOS] [ADDED] - Fixed cursor height on multiline text input
Test Plan
UI After the change
Screen.Recording.2023-03-22.at.11.17.31.PM.mov
Screen.Recording.2023-03-22.at.11.19.21.PM.mov