Fix accessibilityState overwriting view's disabled state on Android

[okwasniewski]

Summary

While I was working on rewriting react-native-slider to Fabric I found a weird bug that prevented the slider to be set as disabled (to be exact: call the method slider.setEnabled(false). As it turned out the accessibilityState (with value: accessibilityState={{disabled: true}} prop occurred after the enabled={false} prop that I was passing to the slider, which lead to both of this props overwrite each other.

Handling of accessibilityState props inside view leads to always overwriting the enabled prop to true (even if we explicitly set it to {disabled: false}.

Workaround for this was to reorder the props, so that the accesibilityState occur before disabled, but I think it's better to not set view.setEnabled(true) if we are passing a disabled property.

Changelog

[Android] [Fixed] - Fix accessibilityState overwriting view's disabled state on Android

Test Plan

Change order of props inside native component implementation (that disabled occurs before accesibilityState). For example: Libraries/Components/Slider/Slider.js

Video showing the bug in RNTester (using Switch component)

SwitchExample.mp4

[facebook-github-bot]

Hi @okwasniewski!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,827,089	-960
android	hermes	armeabi-v7a	7,218,013	-943
android	hermes	x86	8,139,501	-952
android	hermes	x86_64	8,117,600	-955
android	jsc	arm64-v8a	9,704,342	-688
android	jsc	armeabi-v7a	8,458,866	-676
android	jsc	x86	9,654,984	-681
android	jsc	x86_64	10,252,830	-682

Base commit: 3f50440
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 3f50440
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[okwasniewski]

@NickGerleman I've added your suggested fix, and all checks have passed. Can you take a look again?

[react-native-bot]

This pull request was successfully merged by @okwasniewski in f35d18c.

^{When will my fix make it into a release? | Upcoming Releases}