-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update incorrect SwitchChangeEvent
type
#34931
Conversation
a868181
to
c547f86
Compare
Base commit: 14456e7 |
hi @retyui, thanks for the fix! some of the CI tests are failing though, could you take a look? |
@skinsshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@skinsshark nothing critical, I think a retry should fix it: CI/DS logs...// android
* What went wrong:
Execution failed for task ':react-native-gradle-plugin:compileKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':react-native-gradle-plugin:compileKotlin'
> Could not resolve all files for configuration ':react-native-gradle-plugin:compileClasspath'.
> Could not download builder-7.3.0.jar (com.android.tools.build:builder:7.3.0)
> Could not get resource 'https://dl.google.com/dl/android/maven2/com/android/tools/build/builder/7.3.0/builder-7.3.0.jar'.
> Premature end of Content-Length delimited message body (expected: 8,738,708; received: 6,029,280)
//-----------------------
// ios
Executed 173 tests, with 0 failures (0 unexpected) in 0.790 (0.845) seconds
Failing tests:
RNTesterIntegrationTests:
-[RCTLoggingTests testLogging]
-[RCTLoggingTests testLogging]
** TEST FAILED **
./IntegrationTests/launchWebSocketServer.sh: line 9: 10888 Terminated: 15 ./websocket_integration_test_server.js
~/react-native
Process terminated.
error Command failed with signal "SIGTERM". |
17357ac
to
609e1cf
Compare
609e1cf
to
f6b5cfd
Compare
Base commit: b33961d |
@skinsshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @retyui in 5dd2f2e. When will my fix make it into a release? | Upcoming Releases |
Summary: I noticed that typescript type for `onChange` event of `<Switch/>` was incorrect ```tsx <Switch onChange={(event) => { // TS event.value; // boolean event.nativeEvent.value; //TS2339: Property 'value' does not exist on type 'Event'. // JS console.log(event.nativeEvent); // {value:false,target:87} console.log(event.value); // undefined }} /> ``` ## Changelog [General] [Changed] - Typescript: update incorrect `SwitchChangeEvent` type Pull Request resolved: facebook#34931 Test Plan: ... Reviewed By: lunaleaps Differential Revision: D40240552 Pulled By: skinsshark fbshipit-source-id: 4d39d547778de4ac4dc6c94471f05bfbe157d0e5
Summary: I noticed that typescript type for `onChange` event of `<Switch/>` was incorrect ```tsx <Switch onChange={(event) => { // TS event.value; // boolean event.nativeEvent.value; //TS2339: Property 'value' does not exist on type 'Event'. // JS console.log(event.nativeEvent); // {value:false,target:87} console.log(event.value); // undefined }} /> ``` ## Changelog [General] [Changed] - Typescript: update incorrect `SwitchChangeEvent` type Pull Request resolved: facebook#34931 Test Plan: ... Reviewed By: lunaleaps Differential Revision: D40240552 Pulled By: skinsshark fbshipit-source-id: 4d39d547778de4ac4dc6c94471f05bfbe157d0e5
Summary
I noticed that typescript type for
onChange
event of<Switch/>
was incorrectChangelog
[General] [Changed] - Typescript: update incorrect
SwitchChangeEvent
typeTest Plan
...