fix: Update incorrect SwitchChangeEvent type

facebook · Oct 11, 2022 · 609e1cf · 609e1cf
1 parent e4dff28
commit 609e1cf
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 2 deletions.
diff --git a/Libraries/Components/Switch/AndroidSwitchNativeComponent.js b/Libraries/Components/Switch/AndroidSwitchNativeComponent.js
@@ -19,6 +19,7 @@ import * as React from 'react';
 
 type SwitchChangeEvent = $ReadOnly<{|
   value: boolean,
+  target: number,
 |}>;
 
 type NativeProps = $ReadOnly<{|

diff --git a/Libraries/Components/Switch/Switch.d.ts b/Libraries/Components/Switch/Switch.d.ts
@@ -13,6 +13,7 @@ import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ColorValue, StyleProp} from '../../StyleSheet/StyleSheet';
 import {ViewStyle} from '../../StyleSheet/StyleSheetTypes';
 import {ViewProps} from '../View/ViewPropTypes';
+import {NativeSyntheticEvent, TargetedEvent} from '../../Types/CoreEventTypes';
 
 export interface SwitchPropsIOS extends ViewProps {
   /**
@@ -37,10 +38,13 @@ export interface SwitchPropsIOS extends ViewProps {
   tintColor?: ColorValue | undefined;
 }
 
-export interface SwitchChangeEvent extends React.SyntheticEvent {
+export interface SwitchChangeEventData extends TargetedEvent {
   value: boolean;
 }
 
+export interface SwitchChangeEvent
+  extends NativeSyntheticEvent<SwitchChangeEventData> {}
+
 export interface SwitchProps extends SwitchPropsIOS {
   /**
    * Color of the foreground switch grip.

diff --git a/Libraries/Components/Switch/Switch.js b/Libraries/Components/Switch/Switch.js
@@ -27,6 +27,7 @@ import * as React from 'react';
 type SwitchChangeEvent = SyntheticEvent<
   $ReadOnly<{|
     value: boolean,
+    target: number,
   |}>,
 >;
 

diff --git a/Libraries/Components/Switch/SwitchNativeComponent.js b/Libraries/Components/Switch/SwitchNativeComponent.js
@@ -19,6 +19,7 @@ import * as React from 'react';
 
 type SwitchChangeEvent = $ReadOnly<{|
   value: boolean,
+  target: number,
 |}>;
 
 type NativeProps = $ReadOnly<{|

diff --git a/types/__typetests__/index.tsx b/types/__typetests__/index.tsx
@@ -1429,7 +1429,7 @@ const SwitchOnChangePromiseTest = () => (
   <Switch
     onChange={event => {
       const e: SwitchChangeEvent = event;
-      return new Promise(() => e.value);
+      return new Promise(() => e.nativeEvent.value);
     }}
   />
 );