Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate TextInput editable prop #34492

Conversation

gabrieldonadel
Copy link
Collaborator

Summary

This is a follow-up PR of #34444 and it adds a deprecation warning regarding the TextInput component editable prop as requested by @lunaleaps here -> #34444 (comment)

Changelog

[General] [Deprecated] - Adds deprecation warning to TextInput editable prop

Test Plan

  1. Open the RNTester app and navigate to the TextInput page
  2. Observe the warning
Screen.Recording.2022-08-24.at.18.15.50.mov

@gabrieldonadel gabrieldonadel force-pushed the chore/add-text-input-editable-warning branch from c5ba16c to 4bcd09d Compare August 24, 2022 21:17
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 24, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,617,191 +73
android hermes armeabi-v7a 7,031,532 +98
android hermes x86 7,917,346 +49
android hermes x86_64 7,891,041 +46
android jsc arm64-v8a 9,494,876 +56
android jsc armeabi-v7a 8,272,588 +82
android jsc x86 9,432,769 +42
android jsc x86_64 10,025,821 +40

Base commit: f3def13
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f3def13
Branch: main

@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@lunaleaps
Copy link
Contributor

Hey @gabrieldonadel, sorry for the delay -- we're actively discussing this approach in how we want to do deprecations. I think we want to give folks one more release before they get warned. Still figuring out the best way to do that. We need to clean up our deprecation policy and make it more visible. Is it alright if close this PR for now?

@gabrieldonadel
Copy link
Collaborator Author

Hey @gabrieldonadel, sorry for the delay -- we're actively discussing this approach in how we want to do deprecations. I think we want to give folks one more release before they get warned. Still figuring out the best way to do that. We need to clean up our deprecation policy and make it more visible. Is it alright if close this PR for now?

Hey @lunaleaps no worries, I'm closing this and removing the deprecation warning from my PR on the react-native-website repo right now

@LinusU
Copy link
Contributor

LinusU commented Nov 29, 2023

@lunaleaps did the internal discussion continue? Currently the documentation doesn't show any indication that readOnly is preferred over editable:

In fact, since editable comes first in the list this is what I first implemented when looking for an equivalent for disabled on the Web (which I now realise might not be exactly what readOnly is though 🤔).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants