-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add rows prop to TextInput component #34488
feat: Add rows prop to TextInput component #34488
Conversation
Base commit: f3def13 |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hi @gabrieldonadel, thanks for the PR. Could you please rebase this onto |
3d4c49f
to
d757a89
Compare
Sure @cipolleschi, I've just rebased it |
Base commit: f3def13 |
Is there an equivalent to |
Unfortunately no @necolas, but I guess we could implement it using |
Yeah we can look into unifying text input behavior in another PR. Thanks! |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @gabrieldonadel in 49c9ccd. When will my fix make it into a release? | Upcoming Releases |
@lunaleaps @necolas quick question about these new TextInput props, should we deprecate these old props that are being mapped e.g. #34444 (comment)? Should I open a PR for |
Summary: This adds the Android only `rows` prop to TextInput as requested on facebook#34424 mapping the existing `numberOfLines` prop to `rows`. This PR also updates the TextInputExample.android on the RNTester in order to facilitate the manual QA of this. ## Changelog [Android] [Added] - Add rows prop to TextInput component Pull Request resolved: facebook#34488 Test Plan: 1. On Android open the RNTester app and navigate to the TextInput page 2. Test the `TextInput` component through the `Fixed number of lines` section https://user-images.githubusercontent.com/11707729/186300173-7de79799-25b8-48af-99c0-8e3abeae334f.mov Reviewed By: christophpurrer Differential Revision: D38981953 Pulled By: cipolleschi fbshipit-source-id: d4d84b3c0dac7342ba9a65e2491928fbc61ff4f1
Let's hold off on this. There's concern that people don't have time to actively migrate their callsites and will get noise. Sorry about the trouble! |
Summary
This adds the Android only
rows
prop to TextInput as requested on #34424 mapping the existingnumberOfLines
prop torows
. This PR also updates the TextInputExample.android on the RNTester in order to facilitate the manual QA of this.Changelog
[Android] [Added] - Add rows prop to TextInput component
Test Plan
TextInput
component through theFixed number of lines
sectionScreen.Recording.2022-08-23.at.22.52.05.mov