Use NDK 23 only for Windows users.

[cortinico]

Summary:
Bumping the NDK to 23 to prevent build failures due to the NDK
using longer paths.

Changelog:
[Android] [Fixed] - Use NDK 23 only for Windows users.

Differential Revision: D35547459

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D35547459

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 65abc36
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,770,560	+0
android	hermes	armeabi-v7a	7,176,577	+0
android	hermes	x86	8,079,751	+0
android	hermes	x86_64	8,058,467	+0
android	jsc	arm64-v8a	9,645,279	+0
android	jsc	armeabi-v7a	8,419,644	+0
android	jsc	x86	9,594,494	+0
android	jsc	x86_64	10,191,921	+0

Base commit: 65abc36
Branch: main

[RalissonMattias]

@cortinico I can help in the tests, basically just change the file?

[cortinico]

@cortinico I can help in the tests, basically just change the file?

Thanks for that @RalissonMattias

You can find simple instructions on how to test it here: https://gist.github.com/cortinico/6a297ac4c6a2a4633f58f1e4b375dd88

Please publish the gradle scans once you're done with it.

[RalissonMattias]

@cortinico I can help in the tests, basically just change the file?

Thanks for that @RalissonMattias

You can find simple instructions on how to test it here: https://gist.github.com/cortinico/6a297ac4c6a2a4633f58f1e4b375dd88

Please publish the gradle scans once you're done with it.

I tested here and it didn't work

[cortinico]

I tested here and it didn't work

I've updated the .patch file in gist with a new one (fix33611-v2.patch). Could you give it another try (make sure to delete the project and re-create it).

[Ralisson-Mattias]

After applying the new patch, generate new error

[cortinico]

After applying the new patch, generate new error

Thanks for the feedback. I ended up finding a windows machine and finding a (hopefully) working solution. It works locally for me but I'd like someone else to give it another try.

I've updated the .patch file in gist (here https://gist.github.com/cortinico/6a297ac4c6a2a4633f58f1e4b375dd88) with a new one (fix33611-v3.patch). Could you give it another try (make sure to delete the project and re-create it).

[RalissonMattias]

Here still no success.

First git applyt throws errors:

After manually inserting only the fix33611-v3.patch:

After manually combining and entering patches v1 and v3:

[mikehardy]

@cortinico I gave it a go.
-- ❌ First build failed https://gradle.com/s/qzgdhi6kbxlbc
-- ❌ Second build still failed, using v3 of patch from gist https://gradle.com/s/uly2zz74hljzo
-- ironically, when I run git apply fix33611-v3.patch as downloaded via "raw" view mode + save file from browser, in powershell I get "Corrupt file at line 40" which seems to be some sort of unix vs dos patch format thing. Using unix2dos did not result in success but using notepad fix33611-v3.patch and just adding a newline at end of file + save + close resulted in patch that successfully applied 🤷

  make: *** Deleting file 'C:\Users\micro\work\react-random\RN068\.cxx/local/armeabi-v7a/librrc_slider.a'
  C:/Users/micro/AppData/Local/Android/Sdk/ndk/21.4.7075529/build//../toolchains/llvm/prebuilt/windows-x86_64/bin/arm-linux-androideabi-ar: C:\Users\micro\work\react-random\RN068\.cxx/local/armeabi-v7a/objs-debug/rrc_slider/C_/Users/micro/work/react-random/RN068/node_modules/react-native/ReactAndroid/__/ReactCommon/react/renderer/components/slider/platform/android/react/renderer/components/slider/SliderMeasurementsManager.o: No such file or directory
  make: *** [C:/Users/micro/AppData/Local/Android/Sdk/ndk/21.4.7075529/build//../build/core/build-binary.mk:600: C:\Users\micro\work\react-random\RN068\.cxx/local/armeabi-v7a/librrc_slider.a] Error 1
  make: *** Waiting for unfinished jobs....
  make: *** Deleting file 'C:\Users\micro\work\react-random\RN068\.cxx/local/armeabi-v7a/librrc_progressbar.a'
  C:/Users/micro/AppData/Local/Android/Sdk/ndk/21.4.7075529/build//../toolchains/llvm/prebuilt/windows-x86_64/bin/arm-linux-androideabi-ar: C:\Users\micro\work\react-random\RN068\.cxx/local/armeabi-v7a/objs-debug/rrc_progressbar/C_/Users/micro/work/react-random/RN068/node_modules/react-native/ReactAndroid/__/ReactCommon/react/renderer/components/progressbar/android/react/renderer/components/progressbar/AndroidProgressBarShadowNode.o: No such file or directory
  make: *** [C:/Users/micro/AppData/Local/Android/Sdk/ndk/21.4.7075529/build//../build/core/build-binary.mk:600: C:\Users\micro\work\react-random\RN068\.cxx/local/armeabi-v7a/librrc_progressbar.a] Error 1
  make: *** Deleting file 'C:\Users\micro\work\react-random\RN068\.cxx/local/armeabi-v7a/librrc_switch.a'
  C:/Users/micro/AppData/Local/Android/Sdk/ndk/21.4.7075529/build//../toolchains/llvm/prebuilt/windows-x86_64/bin/arm-linux-androideabi-ar: C:\Users\micro\work\react-random\RN068\.cxx/local/armeabi-v7a/objs-debug/rrc_switch/C_/Users/micro/work/react-random/RN068/node_modules/react-native/ReactAndroid/__/ReactCommon/react/renderer/components/switch/androidswitch/react/renderer/components/androidswitch/AndroidSwitchShadowNode.o: No such file or directory
  make: *** [C:/Users/micro/AppData/Local/Android/Sdk/ndk/21.4.7075529/build//../build/core/build-binary.mk:600: C:\Users\micro\work\react-random\RN068\.cxx/local/armeabi-v7a/librrc_switch.a] Error 1

-- ✔️ Advised to move project from C:\Users\micro\work\react-random\RN068 to root of C: and re-try, so, a recompile while it is in C:\RN068 worked https://gradle.com/s/2yhpn6nkfxjro

[cortinico]

-- ✔️ Advised to move project from C:\Users\micro\work\react-random\RN068 to root of C: and re-try, so, a recompile while it is in C:\RN068 worked gradle.com/s/2yhpn6nkfxjro

Awesome thanks for giving it a try. I'll close this PR as we'll merge this instead:

• Building new architecture sources on Windows #33582

Which contains the v3 patch I've added in the gist.

I hope that with RN 0.69, as we moved to CMake, those kind of problems won't appear anymore.

[RalissonMattias]

@cortinico I know you already closed PR but I wanted to report that following the steps of @mikehardy worked correctly here too. Good job, see you later

❌https://gradle.com/s/qxh3ndc6bel4c
✅https://gradle.com/s/c4r6epirook4m

[cortinico]

I know you already closed PR but I wanted to report that following the steps of @mikehardy worked correctly here too. Good job, see you later

Thanks for your feedback @Ralisson-Mattias 🙏 Yup I've closed this one as we're going to merge the other PR: #33582
Thanks again for testing this on your windows machine.

[mganandraj]

On my trials, ndk23 is able to handle long paths, but the build fails because of long commmand lines (>8192 characters) .. I've created another PR with the ndk bump too ..

[react-native-bot]

This pull request was successfully merged by @cortinico in e48a580.

^{When will my fix make it into a release? | Upcoming Releases}