Remove RN Android's bizarre font weight extension pattern #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change to ignore the way that RN's Android code searches for fonts with a
_bold
,_italic
, or_bold_italic
suffix in their filename. In Discord's codebase we just declare the font family, but some of our libraries don't do that (namely react-navigation), so this change should help an issue where some headings are using Roboto because this is trying to find a font matchingfontWeight: 700
.We'll need to revert this change once we rework how we do fonts on RN (since currently we're a bit off-book).