Build Hermes from Source #33396
Closed
Build Hermes from Source #33396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34389875 |
Base commit: 2a5265d |
|
This pull request was exported from Phabricator. Differential Revision: D34389875 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: facebook#33396 This commit fully unplugs the `ReactAndroid` from using hermes from the NPM package and plugs the usage of Hermes via the `packages/hermes-engine` Gradle build. I've used prefab to share the .so between the two builds, so we don't need any extra machinery to make this possible. Moreover, I've added a `buildHermesFromSource` property, which defaults to false when RN is imported, but is set to true when RN is opened for local development. This should allow us to distribute the `react-native` NPM package and users could potentially toggle which source to use (but see below). Changelog: [Android] [Changed] - Build Hermes from Source Reviewed By: hramos Differential Revision: D34389875 fbshipit-source-id: 9879a097e35b51aa67a8e48c766573bbd6df0b7d
cortinico
force-pushed
the
export-D34389875
branch
from
6235249
to
ab60ced
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34389875 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: facebook#33396 This commit fully unplugs the `ReactAndroid` from using hermes from the NPM package and plugs the usage of Hermes via the `packages/hermes-engine` Gradle build. I've used prefab to share the .so between the two builds, so we don't need any extra machinery to make this possible. Moreover, I've added a `buildHermesFromSource` property, which defaults to false when RN is imported, but is set to true when RN is opened for local development. This should allow us to distribute the `react-native` NPM package and users could potentially toggle which source to use (but see below). Changelog: [Android] [Changed] - Build Hermes from Source Reviewed By: hramos Differential Revision: D34389875 fbshipit-source-id: 99452c43adf456156f5280dc37aefb9555ece18a
cortinico
force-pushed
the
export-D34389875
branch
from
ab60ced
to
73687c0
Compare
Base commit: 2a5265d |
|
This pull request was exported from Phabricator. Differential Revision: D34389875 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: facebook#33396 This commit fully unplugs the `ReactAndroid` from using hermes from the NPM package and plugs the usage of Hermes via the `packages/hermes-engine` Gradle build. I've used prefab to share the .so between the two builds, so we don't need any extra machinery to make this possible. Moreover, I've added a `buildHermesFromSource` property, which defaults to false when RN is imported, but is set to true when RN is opened for local development. This should allow us to distribute the `react-native` NPM package and users could potentially toggle which source to use (but see below). Changelog: [Android] [Changed] - Build Hermes from Source Reviewed By: hramos Differential Revision: D34389875 fbshipit-source-id: f29019a865a594676e9d32d294da55aa24626218
cortinico
force-pushed
the
export-D34389875
branch
from
73687c0
to
1e3b8ed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34389875 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: facebook#33396 This commit fully unplugs the `ReactAndroid` from using hermes from the NPM package and plugs the usage of Hermes via the `packages/hermes-engine` Gradle build. I've used prefab to share the .so between the two builds, so we don't need any extra machinery to make this possible. Moreover, I've added a `buildHermesFromSource` property, which defaults to false when RN is imported, but is set to true when RN is opened for local development. This should allow us to distribute the `react-native` NPM package and users could potentially toggle which source to use (but see below). Changelog: [Android] [Changed] - Build Hermes from Source Reviewed By: hramos Differential Revision: D34389875 fbshipit-source-id: c7a9e6d88901d4ef2b1689f8a9e73b8f19d231d0
cortinico
force-pushed
the
export-D34389875
branch
from
1e3b8ed
to
d0ac026
Compare
Summary: Pull Request resolved: facebook#33396 This commit fully unplugs the `ReactAndroid` from using hermes from the NPM package and plugs the usage of Hermes via the `packages/hermes-engine` Gradle build. I've used prefab to share the .so between the two builds, so we don't need any extra machinery to make this possible. Moreover, I've added a `buildHermesFromSource` property, which defaults to false when RN is imported, but is set to true when RN is opened for local development. This should allow us to distribute the `react-native` NPM package and users could potentially toggle which source to use (but see below). Changelog: [Android] [Changed] - Build Hermes from Source Reviewed By: hramos Differential Revision: D34389875 fbshipit-source-id: e5912d24dc11a2cc7044e3615d2ff4c41fcedd30
|
This pull request was exported from Phabricator. Differential Revision: D34389875 |
cortinico
force-pushed
the
export-D34389875
branch
from
d0ac026
to
2e4c4a0
Compare
|
This pull request was successfully merged by @cortinico in a3d9892. When will my fix make it into a release? | Upcoming Releases |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 12, 2022
Summary: Pull Request resolved: facebook#33396 This commit fully unplugs the `ReactAndroid` from using hermes from the NPM package and plugs the usage of Hermes via the `packages/hermes-engine` Gradle build. I've used prefab to share the .so between the two builds, so we don't need any extra machinery to make this possible. Moreover, I've added a `buildHermesFromSource` property, which defaults to false when RN is imported, but is set to true when RN is opened for local development. This should allow us to distribute the `react-native` NPM package and users could potentially toggle which source to use (but see below). Changelog: [Android] [Changed] - Build Hermes from Source Reviewed By: hramos Differential Revision: D34389875 fbshipit-source-id: 107cbe3686daf7607a1f0f75202f24cd80ce64bb
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33396 This commit fully unplugs the `ReactAndroid` from using hermes from the NPM package and plugs the usage of Hermes via the `packages/hermes-engine` Gradle build. I've used prefab to share the .so between the two builds, so we don't need any extra machinery to make this possible. Moreover, I've added a `buildHermesFromSource` property, which defaults to false when RN is imported, but is set to true when RN is opened for local development. This should allow us to distribute the `react-native` NPM package and users could potentially toggle which source to use (but see below). Changelog: [Android] [Changed] - Build Hermes from Source Reviewed By: hramos Differential Revision: D34389875 fbshipit-source-id: 107cbe3686daf7607a1f0f75202f24cd80ce64bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit fully unplugs the
ReactAndroidfrom using hermes from the NPM package and plugs the usage of Hermes via thepackages/hermes-engineGradle build.I've used prefab to share the .so between the two builds, so we don't need any extra machinery to make this possible.
Moreover, I've added a
buildHermesFromSourceproperty, which defaults to false when RN is imported, but is set to true when RN is opened for local development. This should allow us to distribute thereact-nativeNPM package and users could potentially toggle which source to use.Changelog:
[Android] [Changed] - Build Hermes from Source
Reviewed By: hramos
Differential Revision: D34389875