Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Hermes from Source #33396

Closed
wants to merge 2 commits into from
Closed

Build Hermes from Source #33396

wants to merge 2 commits into from

Commits on Mar 11, 2022

  1. Build Hermes from Source (facebook#33396) 

    Summary:
Pull Request resolved: facebook#33396

This commit fully unplugs the `ReactAndroid` from using hermes from the NPM package and plugs the usage of Hermes via the `packages/hermes-engine` Gradle build.

I've used prefab to share the .so between the two builds, so we don't need any extra machinery to make this possible.

Moreover, I've added a `buildHermesFromSource` property, which defaults to false when RN is imported, but is set to true when RN is opened for local development. This should allow us to distribute the `react-native` NPM package and users could potentially toggle which source to use (but see below).

Changelog:
[Android] [Changed] - Build Hermes from Source

Reviewed By: hramos

Differential Revision: D34389875

fbshipit-source-id: e5912d24dc11a2cc7044e3615d2ff4c41fcedd30
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    2e4c4a0 View commit details
    Browse the repository at this point in the history

  2. Just run :ReactAndroid:assembleDebug inside the Docker image

    @cortinico
    cortinico authored Mar 11, 2022
    Configuration menu
    Copy the full SHA
    e950642 View commit details
    Browse the repository at this point in the history