Implement native TextInput autoFocus on Android #27924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This was referenced Feb 1, 2020
facebook-github-bot
approved these changes
Feb 1, 2020
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @janicduplessis in 055a41b. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 2, 2020
Summary: Follow up to #27803 and #27924. We no longer need to call focus on mount from JS as both iOS and Android implements it natively now. ## Changelog [General] [Fixed] - Remove JS autoFocus implementation Pull Request resolved: #27923 Test Plan: Test that focus works in RN Tester with this, #27803 and #27924 Differential Revision: D19956373 Pulled By: TheSavior fbshipit-source-id: 5d99ead55011663b3edaf499ac7616765a24cb50
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Follow up to facebook#27803. To keep consistency between the implementations this also implements autoFocus natively on Android. This will allow removing the JS auto focus logic completely. ## Changelog [Android] [Fixed] - Implement native TextInput autoFocus on Android Pull Request resolved: facebook#27924 Test Plan: Test using the TextInput example in RN tester. Differential Revision: D19674506 Pulled By: TheSavior fbshipit-source-id: 9cbb517fc69bccd11f5292a1ccb4acea2e3713e9
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Follow up to facebook#27803 and facebook#27924. We no longer need to call focus on mount from JS as both iOS and Android implements it natively now. ## Changelog [General] [Fixed] - Remove JS autoFocus implementation Pull Request resolved: facebook#27923 Test Plan: Test that focus works in RN Tester with this, facebook#27803 and facebook#27924 Differential Revision: D19956373 Pulled By: TheSavior fbshipit-source-id: 5d99ead55011663b3edaf499ac7616765a24cb50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #27803. To keep consistency between the implementations this also implements autoFocus natively on Android. This will allow removing the JS auto focus logic completely.
Changelog
[Android] [Fixed] - Implement native TextInput autoFocus on Android
Test Plan
Test using the TextInput example in RN tester.